2032105 - Null string is added to urlbar when opening local search engines using search mode switcher

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea]]

Attachment: "null" string

Found in

• Firefox 151.0a1 2026-04-15;

Affected versions

• Firefox Nightly 151.0a1;

Tested platforms

• Affected platform: Windows 11, Ubuntu 24, macOS 15;
• Unaffected platforms: N/A;

Steps to reproduce

1. Open a new tab and click on the Unified Search Button (search mode switcher);
2. Select any local search engine - Tabs / Bookmarks / History / Actions.

Expected result

• Tabs opened / Bookmarked sites / websites from History or the set of Actions are correctly displayed.

Actual result

• null string is shown in the address bar. There are no errors in the web / browser console.

Regression range

• last good: 2026-04-07
• first bad: 2026-04-08
• pushlog url
• Found commit message:
  Bug 2026387 - Perform search when user selects search engine. r=dao,urlbar-reviewers,mbeier

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daleharvey, since you are the author of the regressor, bug 2026387, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Moritz Beier [:mbeier]]

Ugh we really should have caught this. I reorganized this part of the code in bug Bug 1961789 so we should base the fix on that patch.

Comment 3

[Moritz Beier [:mbeier]]

Attachment: Bug 2032105 - Use input value instead of userTypedValue when entering search mode via unified search button. r?#urlbar-reviewers

Comment 4

[Moritz Beier [:mbeier]]

I noticed that the same change that caused this bug also caused bug 1963006 to reappear. This patch should fix both.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7fa2309adfb
https://hg.mozilla.org/integration/autoland/rev/9b6a95063d54
Use input value instead of userTypedValue when entering search mode via unified search button. r=urlbar-reviewers,dao

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/9b6a95063d54

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/9b6a95063d54

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-04-15 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 152.0a1 and Firefox 151.0.b1 on Windows 10, Ubuntu 22, macOS 15.