2032928 - Clarify supported properties in tabs.Tab implementation on Android

Status: RESOLVED FIXED

(WebExtensions :: Android, task)

Description

[Rob Wu [:robwu]]

The tabs.Tab implementation for Android has several fields that contain an implementation that is effectively dead code, due to their reliance on implementation details from Fennec that have disappeared after Firefox 68 (when the Firefox for Android version was revamped, codename Fenix).

I came across this again when I was reviewing a patch, so let's clean this up to avoid more confusion.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2032928 - Clarify misleading Tab API support for Android

Remove misleading dead code, and add comments referencing relevant bugs
where applicable.

Comment 2

[Rob Wu [:robwu]]

Also putting dev-doc-needed here, because the BCD for tabs.Tab still lists properties as supported on Firefox for Android even when they are not. For the actual support status, see the patch for this bug, and look at the properties at class Tab extends TabBase {.

And while we are at updating the BCD, please also update the BCD for tabs.onUpdated: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/onUpdated#browser_compatibility
The only supported changeInfo right are status, url and title. Everything else is not supported on Android right now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/905400f97041
https://hg.mozilla.org/integration/autoland/rev/fc5cb57f56fd
Clarify misleading Tab API support for Android r=willdurand,geckoview-reviewers,ohall

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fc5cb57f56fd