2032973 - Typing something in the urlbar and clicking an engine in the unified search button popup records a urlbar abandonment event

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Moritz Beier [:mbeier]]

STR:

1. Type something in the urlbar.
2. Open the unified search button and choose a search engine

Expected:
Urlbar engagement event or no event

Actual:
Urlbar abandonment event

Comment 1

[Moritz Beier [:mbeier]]

Note that pressing shift was required to trigger this before bug 1915250

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2032973 - Typing something in the urlbar and clicking an engine in the unified search button popup records a urlbar abandonment event. r?adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f25eabd63c15
https://hg.mozilla.org/integration/autoland/rev/102dacfa9b16
Typing something in the urlbar and clicking an engine in the unified search button popup records a urlbar abandonment event. r=adw,urlbar-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/102dacfa9b16

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: No user impact, telemetry would be inaccurate in some cases
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2032973#c0
• Risk associated with taking this patch: low
• Explanation of risk level: One line change covered by automated tests
• String changes made/needed?: no
• Is Android affected?: no

Comment 7

[Moritz Beier [:mbeier]]

Attachment: Bug 2032973 - Typing something in the urlbar and clicking an engine in the unified search button popup records a urlbar abandonment event.

Original Revision: https://phabricator.services.mozilla.com/D296368

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e84d0e96a106
https://hg.mozilla.org/releases/mozilla-beta/rev/a1a08247552f

Comment 9

[Petruta Horea [:phorea]]

Hi Moritz!

Are there any other probes, aside from the ones listed below, that require verification for this scenario?
Glean.urlbar.engagement.testGetValue();
Glean.urlbar.abandonment.testGetValue();
Glean.browserSearchContent.urlbar.testGetValue();

Thank you!

Comment 10

[Moritz Beier [:mbeier]]

That should be it. Thanks!

Comment 11

[Petruta Horea [:phorea]]

Verified the above probes are recorded using Firefox 151 beta 7 and latest Nightly 152.0a1 across platforms.