2032991 - Don't perform search when adding a new engine from search engine switcher

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Petruta Horea [:phorea]]

Found in

• Firefox 151.0a1 2026-04-16;

Affected versions

• Firefox Nightly 151.0a1;

Tested platforms

• Affected platform: Windows 11, Ubuntu 24, macOS 15;
• Unaffected platforms: none

Steps to reproduce

1. Go to a page that offers open search engines (eg: youtube.com).
2. Perform a change to url link to enter the edit mode so that USB button is shown - add a space at the end of the url link.
3. Open search engine switcher and make sure the option to add the search engine is shown next to the Search Settings.
4. Select the option to add the search engine.

Expected result

• Newly added search engine shouldn't perform search after its own url.
• Before bug 2026387, the search mode for the open search engine was opened.

Actual result

• Search engines searches for the url already opened in the address bar (youtube eg)

Regression range

• last good: 2026-04-07
• first bad: 2026-04-08
• pushlog url
• Found commit message:
  Bug 2026387 - Perform search when user selects search engine. r=dao,urlbar-reviewers,mbeier

Comment 1

[BugBot [:suhaib / :marco]]

:daleharvey, since you are the author of the regressor, bug 2026387, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 2032991 - Enter search mode when installing new engine.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ceb215aa8ba7
https://hg.mozilla.org/integration/autoland/rev/1d69cfd91212
Enter search mode when installing new engine. r=urlbar-reviewers,daisuke

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1d69cfd91212

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: User experiences regression introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=2026387
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: 1. Go to a page that offers open search engines (eg: youtube.com).

2. Perform a change to url link to enter the edit mode so that USB button is shown - add a space at the end of the url link.
3. Open search engine switcher and make sure the option to add the search engine is shown next to the Search Settings.
4. Select the option to add the search engine.

• Risk associated with taking this patch: low
• Explanation of risk level: Small change that is covered by tests
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: Bug 2032991 - Enter search mode when installing new engine.

Original Revision: https://phabricator.services.mozilla.com/D295384

Comment 8

[Dale Harvey (:daleharvey)]

Yeh probably best be uplifted so we dont regress for a release

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ffb22e01d061
https://hg.mozilla.org/releases/mozilla-beta/rev/9807a3b8ef1c

Comment 10

[Petruta Horea [:phorea]]

Verified as fixed using latest Nightly 152.0a1 using Win 11 and macOS 15.
I will leave the "qe-verify+" flag set until Firefox Beta 151.0b5 build will be available.

Comment 11

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 151 beta 5 across platforms.