2032997 - HTTP error code missing on new error page for contentEncodingError

Status: RESOLVED FIXED

(Firefox :: Security, defect, P2)

Description

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

Attachment: content-encoding.png

Moving Bug 2027209 comment 9 into own bug:

Like HTTP error that were updated in Bug 2023800, the error contentEncodingError happens after establishing the connection to the server. It is also somewhat later due to being an error about the HTTP body, not HTTP headers. We should both:

1. Show the HTTP status code if it is an error (similar to Bug 2023800) and
2. Replace the phrase "can’t connect to the server at" with something that describes the situation more correctly.

I'm attach a screenshot of how it looks like now/before. Sorry, I'm unable to share the website, because it is a private one. And I haven't found a good test website / haven't setup one yet.

I see that (2) is currently getting addressed in Bug 2027209.

Opening a separate for (1) as per Bug 2027209 comment 10.

Comment 1

[Mathew Hodson]

Attachment: Bug 2032997 - Add HTTP error code to encoding error page r=jbrown

Comment 2

[Mathew Hodson]

@jbrown, should the HTTP response error code be added to the "invalidHeaderValue" page as well?

Comment 3

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

Seems like this was already addressed in Bug 2027209 patch D295031.

https://github.com/mozilla-firefox/firefox/commit/8a540e7c99aa
https://hg.mozilla.org/mozilla-central/rev/267da15baa9d

Thanks @Mathew for taking the time to write the patch, sorry that it was now fixed in another bug.

Comment 4

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

Attachment: new-content-encoding.png

The new content encoding page now looks like this (latest Nightly):

Content Encoding Error

The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.

What can you do about it?

The issue is most likely with the website, and there is nothing you can do to resolve it. You can notify the website’s administrator about the problem.

Comment 5

[Mathew Hodson]

(In reply to Manuel Bucher [:manuel] from comment #3)

Seems like this was already addressed in Bug 2027209 patch D295031.

Wasn't this bug filed for (1) "Show the HTTP status code if it is an error (similar to Bug 2023800)"
Only (2) was fixed in the other bug. The HTTP response status that was shown on the old page like "Error code: 500 Internal Server Error" isn't on the new page, which is what my patch adds.

Comment 6

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

Ah thats true. Sorry! My mistake.

Comment 7

[Mathew Hodson]

Re-adding needinfo for @jbrown

(In reply to Mathew Hodson from comment #2)

@jbrown, should the HTTP response error code be added to the "invalidHeaderValue" page as well?

Comment 8

[Jack Brown]

Ideally it would be nice to add the HTTP response error code to the invalidHeaderValue page, but from playing around with it a bit it seems like it's not as simple as adding showResponseStatus: true to the error config in this case. This particular error looks like it fires during header parsing, and I think that means we don't have access to the response status.

In nsHttpChannel::OnStartRequest around line 9035 mResponseHead is only taken from the transaction if NS_SUCCEEDED(mStatus) is true, mResponseHead being the parsed HTTP response headers (including the status code) and NS_SUCCEEDED(mStatus) being a check that the channel hasn't already encountered an error.

Maybe this should be addressed in a follow-up bug?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b885f3a091ab
https://hg.mozilla.org/integration/autoland/rev/0dfa525749c2
Add HTTP error code to encoding error page r=jbrown

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0dfa525749c2