2033008 - Remove the further abstracted primitive layer of "dimension" design tokens

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Jules Simplicio [:jules]]

We discussed as a group and are favoring the t-shirt scale for size / space over the more prescriptive number namings given to dimension tokens that we shipped on 2005767. So we decided to revert the usage of that abstracted primitive layer and stick to the existing size and space tokens.

All dimension tokens using them should go back to the raw value they were assigned to. We have to look around and clean up dimension token usage.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2033008 - Remove the primitive dimension design tokens. r?hjones!

Every token keeps its resolved value; the panel promo gaps and the smartbar glow bleed move to the equivalent space tokens, which makes those two font-relative.

The Nova overrides for the item sizes and the medium icon size now repeat the brand values, so the Figma importer drops them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20c431dfdf6e
https://hg.mozilla.org/integration/autoland/rev/5d7fdbfbebb9
Remove the primitive dimension design tokens. r=desktop-theme-reviewers,tabbrowser-reviewers,nsharpley,emilio

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5d7fdbfbebb9