2033055 - "Update Add-ons Automatically" menu item does not have checkmark any more

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Rob Wu [:robwu]]

STR:

1. Visit about:addons
2. Click on the settings button (cog) in the upper-right corner.
3. Look at the Update Add-ons Automatically menu item.

Expected:

• It should be checked.

Actual:

• It is not checked.
• When I step through with a debugger, I see that when we try to set the checked state in onUpdateModeChanged, that this.toggleUpdatesEl.checked is unexpectedly not a getter, implying that its custom element definition is somehow not loaded.

mozregression points to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7834ac686ade4f1abf049c4220f64860aa3c2beb&tochange=aac53931d99ba7dffa92666e032d9cfa064c703d

This was regressed by bug 2025900.

Comment 1

[Rob Wu [:robwu]]

Likely unrelated, but while looking at a patch in bug 2025900, I see a compat layer at https://searchfox.org/firefox-main/rev/0ae2fcae6a70566ab9e13e401480387b34911bad/toolkit/content/widgets/panel-list/panel-list.js#13. The import() call is a dynamic import, which means that the code is behaviorally different from the original. If the intent is to behave as before, then using ChromeUtils.importESModule instead of dynamic import() may make more sense.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:mbeier, since you are the author of the regressor, bug 2025900, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi :mbeir
I took a brief look into this because I'm working on a refactoring in this area and I was curious about what may be going on,
using the STR Rob described in comment 0 and confirmed that Rob is right that by the time the onUpdateModeChanged is hit for the first time this.toggleUpdatesEl.constructor is HTMLElement (instead of a PanelItem).

I noticed though that the document.readyState is "interactive" at that time, and that the customElements.setElementCreationCallback registered from toolkit/content/customElements.js that is supposed to load the panel-list.mjs (from here) is actually firing later on (after the onUpdateModeChanged linked in comment 0 has been already executed, and so the panel-item will not be checked as it should have been).

Looking to the changes in the two patches landed from Bug 2026900, I think that panel-list likely used to be loaded earlier before Bug 2025900 because the customElements.setElementCreationCallback registering the callback that loads the .js shared custom elements is registered right away, whereas the other customElements.setElementCreationCallback callback that imports the .mjs shared custom elements is registered on DOMContentLoaded, that would explain why by the time onUpdateModeChanged is executed panel-list isn't loaded yet but it gets loaded as expected later on.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2025900

Comment 5

[Moritz Beier [:mbeier]]

Attachment: Bug 2033055 - Explicitly import panel-list in aboutaddons. r?robwu

Comment 6

[Moritz Beier [:mbeier]]

The dynamic import() in the newtab shim is likely not an issue because the newtab code loads it using <script async.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1e03ac80eb31
https://hg.mozilla.org/integration/autoland/rev/53b3a26cf290
Explicitly import panel-list in aboutaddons. r=rpl

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/53b3a26cf290

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Moritz Beier [:mbeier]]

Attachment: Bug 2033055 - Explicitly import panel-list in aboutaddons.

Original Revision: https://phabricator.services.mozilla.com/D296053

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: It looks like automatic add-on updates are disabled even if they are enabled.
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2033055#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Imports a module that would be imported anyway earlier
• String changes made/needed?: no
• Is Android affected?: no

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0720a080daa7
https://hg.mozilla.org/releases/mozilla-beta/rev/8c36cec7ff01

Comment 14

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (152.0a1/20260426211850) and Beta (151.0b3/20260424174848 from https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=8c36cec7ff010ddf8dd1d848029550ae6a191343) under Windows 11 and Ubuntu 25.10.

The "Update Add-ons Automatically" menu item now has a checkmark. Disabling/Enabling the option hides/shows the checkmark accordingly.