getipnodebyxxxx routines not threadsafe on OpenVMS

RESOLVED FIXED in 4.4

Status

NSPR
NSPR
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Colin Blake, Assigned: Wan-Teh Chang)

Tracking

other
DEC
OpenVMS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

14 years ago
It turns out that the getipnodebyxxxx routines provided by TCP/IP Services for
OpenVMS are not threadsafe (I have reported this internally as PTR 30-5-415 in
library OSSG). But until the problem gets fixed, I have to patch prnetdb.c to
work around the bug (see attachment in next reply).

If I were to change the "#ifdef VMS" to "#ifdef PR_GETIPNODE_NOT_THREADSAFE" or
something like that, and then define PR_GETIPNODE_NOT_THREADSAFE in
nsprpub/config/OpenVMS.mk, is this something that could/should be checked in?
(Reporter)

Comment 1

14 years ago
Created attachment 121649 [details] [diff] [review]
Current patch

This is my current workaround.
(Assignee)

Comment 2

14 years ago
Yes, please use something like PR_GETIPNODE_NOT_THREADSAFE.
You'd need to define that macro in nsprpub/configure.in.
nsprpub/config/OpenVMS.mk is obsolete.
Status: NEW → ASSIGNED
(Reporter)

Comment 3

14 years ago
Created attachment 122013 [details] [diff] [review]
Proposed patch

This version of the patch uses PR_GETIPNODE_NOT_THREADSAFE, and defines it in
the OpenVMS section of configure.in.
Attachment #121649 - Attachment is obsolete: true
(Reporter)

Updated

14 years ago
Attachment #122013 - Flags: review?(wtc)
(Assignee)

Comment 4

14 years ago
Created attachment 122027 [details] [diff] [review]
Proposed patch v1.1

This is essentially the same as Colin's patch.	I only made
some changes to conform to the coding style (of the placement
of curly braces) and to avoid this nested ifdef and if, which
I find difficult to understand:

+#ifndef PR_GETIPNODE_NOT_THREADSAFE
     if (_pr_ipv6_is_present == PR_FALSE)
+#endif
	 UNLOCK_DNS();
Attachment #122013 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #122013 - Flags: review?(wtc)
(Assignee)

Updated

14 years ago
Attachment #122027 - Flags: review?(colin)
(Reporter)

Updated

14 years ago
Attachment #122027 - Flags: review?(colin) → review+
(Reporter)

Comment 5

14 years ago
Comment on attachment 122027 [details] [diff] [review]
Proposed patch v1.1

Can this get into 1.4b?
Attachment #122027 - Flags: approval1.4b?
Attachment #122027 - Flags: approval1.4b? → approval1.4b+
(Reporter)

Comment 6

14 years ago
I believe this fix is checked in now. So the bug can be closed?
(Assignee)

Comment 7

14 years ago
Yes, the fix has been checked in.  Marked the bug fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4
You need to log in before you can comment on or make changes to this bug.