203318 - 008filter.t fails to do chdir $topdir - if @Support::Templates::include_paths returns more than one path

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Tobias Burnus]

This is perl, v5.6.1 built for i386-linux.

If I run ./runtests.sh --verbose 008filter
this fails after the first checked directory (e.g. templates/de/default).

The problem is here:
---------------<cut>-----------------------------
my $topdir = cwd;

foreach my $path (@Support::Templates::include_paths) {
    $path =~ m|template/([^/]+)/|;
    my $lang = $1; 
    chdir $topdir; # absolute path
    ok(0, "TOPDIR: $topdir / cwd: ".cwd." / path: $path\n");
--------------<cut>------------------------------
The ok-line I inserted shows:

a) first loop run:
not ok 1 - TOPDIR: /web/server/bugzilla/docroot / cwd:
/web/server/bugzilla/docroot / path: template/de/default

b) second loop run:
not ok 88 - TOPDIR: /web/server/bugzilla/docroot / cwd:
/web/server/bugzilla/docroot/template/de/default / path: template/en/default

Why is cwd not $topdir in the second loop run?

(The problems I have are obvious: I cannot check more than one directory at one
./runtests run -- needing to hide the directories one by one for the
@Support::Templates::include_paths command)

Comment 1

[Tobias Burnus]

Attachment: Change order, so cwd comes before $/ = undef;

Thanks to Jens Dreger (our local PERL guru) for finding the error:
 $/ = undef;   # normally $/ is "\n"
 my $topdir = cwd;
saves "dir\n" instead of "dir" which doesn't exist. Therefore chdir $topdir
fails (silently) and it works once.
(in the ok output I forgot a few line breaks)

Comment 2

[Tobias Burnus]

Reassign to me.

Comment 3

[Tobias Burnus]

Attachment: New version, fixes additional problem

This code
     chdir $topdir; # absolute path
     my @testitems = Support::Templates::find_actual_files($path);
left me for custom/ in the directory $topdir/$path/bugs/create. I have no idea
why, but it did!
I therefore added a chdir $topdir; afterwards.

Since I got a bit confused whether (en) is (en/custom) or (en/default), I
changed this too.

Comment 4

[Gervase Markham [:gerv]]

Please don't use the name "version" for the variable that has the value "custom"
or default"; version implies version number. A better name might be "flavour",
or something. Otherwise, looks good.

Gerv

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 121661 [details] [diff] [review]
New version, fixes additional problem

Vitaly had mentioned this before we shipped and I absolutely could not
reproduce it no matter how hard I tried.  The $/ thing makes perfect sense
though.  I wonder if Cwd works even with $/ cleared on Mac OS X (which is where
I was doing all my testing) or perhaps chdir ignores the \n on the end on Mac
OS X or something....  anyhow, this works.

Comment 6

[Tobias Burnus]

gerv: ok, I'll call it "flavor" (not "flavour" ;-)

Comment 7

[Vitaly Fedrushkov]

'cwd' apparently uses 'chomp' which in turn depends on $/ value.  
It can be demonstrated with chomp('cwd') not working there, either.

Comment 8

[Dave Miller [:justdave]]

go for it.  please check it in on both the 2.16 branch and the tip.

Comment 9

[Tobias Burnus]

HEAD
Checking in t/008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v  <--  008filter.t
new revision: 1.3; previous revision: 1.2
done

BUGZILLA-2_16-BRANCH
Checking in 008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v  <--  008filter.t
new revision: 1.1.2.2; previous revision: 1.1.2.1
done