2033242 - Rename ownerDocGlobal to documentGlobal, and use it in some relevant places.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2033242 - Rename ownerDocGlobal to documentGlobal, and use it where appropriate in child actors and remote/. r=#firefox-desktop-core-reviewers!

Child actors generally deal with content nodes, and those can be
adopted, in order to preserve behavior, switch to the new
.documentGlobal.

Fix + rename the use-ownerGlobal lint since now it's wrong.
.ownerDocument.defaultView is .documentGlobal, not .ownerGlobal now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/200837ed3b75
https://hg.mozilla.org/integration/autoland/rev/733c6fd00137
Rename ownerDocGlobal to documentGlobal, and use it where appropriate in child actors and remote/. r=firefox-desktop-core-reviewers ,credential-management-reviewers,devtools-reviewers,migration-reviewers,frontend-codestyle-reviewers,ai-platform-reviewers,jdescottes,dimi,dao,Gijs,webidl,smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6e5fd4dde87
https://hg.mozilla.org/integration/autoland/rev/0ee7706e4e0b
Revert "Bug 2033242 - Rename ownerDocGlobal to documentGlobal, and use it where appropriate in child actors and remote/. r=firefox-desktop-core-reviewers ,credential-management-reviewers,devtools-reviewers,migration-reviewers,frontend-codestyle-reviewers,ai-platform-reviewers,jdescottes,dimi,dao,Gijs,webidl,smaug" for causing node failures @use-documentGlobal.mjs.

Comment 4

[agoloman]

Backed out for causing node failures @use-documentGlobal.mjs.

• Backout link
• Push with failures
• Failure Log
• Failure Log unit

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1ea0903443b
https://hg.mozilla.org/integration/autoland/rev/8ecf9d1cf7ae
Rename ownerDocGlobal to documentGlobal, and use it where appropriate in child actors and remote/. r=firefox-desktop-core-reviewers ,credential-management-reviewers,devtools-reviewers,migration-reviewers,frontend-codestyle-reviewers,ai-platform-reviewers,jdescottes,dimi,dao,Gijs,webidl,smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f52b931935dc
https://hg.mozilla.org/integration/autoland/rev/3e518ca27ea2
Fix a couple edge cases I missed where things can be not nodes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c148416eaf2
https://hg.mozilla.org/integration/autoland/rev/2b41589bd9e5
Fix GeckoView ScrollDelegateChild check.

Comment 8

[rperta]

https://hg.mozilla.org/mozilla-central/rev/8ecf9d1cf7ae
https://hg.mozilla.org/mozilla-central/rev/3e518ca27ea2
https://hg.mozilla.org/mozilla-central/rev/2b41589bd9e5

Comment 9

[Mathew Hodson]

Uplifted to Firefox 151 in https://github.com/mozilla-firefox/firefox/commit/ccffd4c6ed1b