2033273 - Stylistic adjustments and cleanup of {Base}Profiler platform-dependent code

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task)

Description

[Rong Bao [:csmantle]]

This is separated from Bug 2023167, including the following parts of the original bug:

• Part 1: Move field initializers of {Base}Profiler's Registers class to declaration.
• Part 4: (Drive-by) Fix typo: "rEDZONE" -> "REDZONE".
• Part 5: (Drive-by) Lower constant MOZ_ASSERTs to static_asserts.

These changes are not related to RV64 or LA64 ports, and it would probably help keep the original bug focused.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Bug 2033273 - Part 1: Move field initializers of {Base}Profiler's Registers class to declaration. r=#profiler-reviewers!

Comment 2

[Rong Bao [:csmantle]]

Attachment: Bug 2033273 - Part 2: Fix typo: "rEDZONE" -> "REDZONE". r=#profiler-reviewers!

Comment 3

[Rong Bao [:csmantle]]

Attachment: Bug 2033273 - Part 3: Lower constant MOZ_ASSERTs to static_asserts. r=#profiler-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d7fa34701906
https://hg.mozilla.org/integration/autoland/rev/12bb432e7133
Part 1: Move field initializers of {Base}Profiler's Registers class to declaration. r=profiler-reviewers,canaltinova
https://github.com/mozilla-firefox/firefox/commit/02767c8778c4
https://hg.mozilla.org/integration/autoland/rev/29f6856161a3
Part 2: Fix typo: "rEDZONE" -> "REDZONE". r=profiler-reviewers,canaltinova
https://github.com/mozilla-firefox/firefox/commit/39ebb8c8c901
https://hg.mozilla.org/integration/autoland/rev/93b09a7a1abb
Part 3: Lower constant MOZ_ASSERTs to static_asserts. r=profiler-reviewers,canaltinova

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/12bb432e7133
https://hg.mozilla.org/mozilla-central/rev/29f6856161a3
https://hg.mozilla.org/mozilla-central/rev/93b09a7a1abb