2033420 - Implement RTCEncodedFrameMetadata.receiveTime

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Andreas Pehrson [:pehrsons]]

Bug 2028060 added attributes mimeType, rtpTimestamp and audioLevel to RTCEncodedFrameMetadata. This is a followup to also add receiveTime.

Because of receive timestamp rounding to milliseconds in libwebrtc, they can appear up to half a millisecond into the future, breaking tests. Upstream change https://issues.webrtc.org/issues/42223979 handles that. It's technically orthogonal as the API surface doesn't change, but I think it would be a bad idea to land the webidl change prior to the upstream fix.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2033420 - For webrtc-encoded-transform WPT set prefs and update expectations. r?bwc

This mainly removes TIMEOUT expectations, as prefs disable mDNS in CI.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2033420 - Remove unnecessary includes in RTCEncoded*Frame.cpp. r?bwc

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2033420 - Refactor RTCStatsTimestampMaker creation to make it more modular. r?bwc

Also fix some comments, as the DomRealtime clock referred to the wrong epoch.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2033420 - Implement RTCEncodedFrameMetadata.receiveTime. r?bwc

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 2033420 - Cherry-pick upstream libwebrtc commit 273009d2fa r?mjf

Upstream commit: https://webrtc.googlesource.com/src/+/273009d2fa8fe3027d4c9a31e8944e2e1e3e8d4e
Move EncodedFrame's receive time to Timestamp

   Bug: webrtc:42223979
   Change-Id: I58db2fbd8ce42bbbb3725b37047f91f4a113b81d
   Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465242
   Commit-Queue: Andreas Pehrson <[e-mail]>
   Reviewed-by: Danil Chapovalov <[e-mail]>
   Reviewed-by: Erik Språng <[e-mail]>
   Cr-Commit-Position: refs/heads/main@{#47526}

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/542f4f756116
https://hg.mozilla.org/integration/autoland/rev/125c53ffd916
For webrtc-encoded-transform WPT set prefs and update expectations. r=bwc
https://github.com/mozilla-firefox/firefox/commit/f2523a4fa69e
https://hg.mozilla.org/integration/autoland/rev/5295cbed89a8
Remove unnecessary includes in RTCEncoded*Frame.cpp. r=bwc
https://github.com/mozilla-firefox/firefox/commit/f398a9b719c3
https://hg.mozilla.org/integration/autoland/rev/87983c952548
Refactor RTCStatsTimestampMaker creation to make it more modular. r=bwc
https://github.com/mozilla-firefox/firefox/commit/63dc6d879c5e
https://hg.mozilla.org/integration/autoland/rev/912f08f3f04a
Implement RTCEncodedFrameMetadata.receiveTime. r=bwc,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/061cb2539f20
https://hg.mozilla.org/integration/autoland/rev/46feaf58fe14
Cherry-pick upstream libwebrtc commit 273009d2fa r=mjf

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/125c53ffd916
https://hg.mozilla.org/mozilla-central/rev/5295cbed89a8
https://hg.mozilla.org/mozilla-central/rev/87983c952548
https://hg.mozilla.org/mozilla-central/rev/912f08f3f04a
https://hg.mozilla.org/mozilla-central/rev/46feaf58fe14