Closed Bug 2033436 Opened 7 months ago Closed 7 months ago

ClientManagerService::MatchAll allows cross-origin client URL disclosure from compromised renderer

Categories

(Core :: DOM: Service Workers, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 2018164

People

(Reporter: pakhunov.anton.n, Unassigned)

Details

(Keywords: reporter-external)

Attachments

(1 file, 1 obsolete file)

ClientManagerService::MatchAll (dom/clients/manager/ClientManagerService.cpp:523) receives ThreadsafeContentParentHandle* aOriginContent representing the calling content process identity, but never validates it against aArgs.serviceWorker().principalInfo(). A compromised renderer can forge ClientMatchAllArgs with an arbitrary victim origin and includeUncontrolled=true to enumerate URLs of all open browser windows/tabs at that origin.

Handler: dom/clients/manager/ClientManagerService.cpp:523
IPDL direction: PClientManagerOp in parent: block (child->parent), PClientManager.ipdl:29

Exploit path:

  1. Compromised content process crafts ClientMatchAllArgs with victim origin in serviceWorker().principalInfo().originNoSuffix and includeUncontrolled=true
  2. Sends via SendPClientManagerOpConstructor
  3. ClientManagerOpParent::DoServiceOp passes to ClientManagerService::MatchAll
  4. MatchAll filters mSourceTable by principalInfo (forged) only - aOriginContent is unused
  5. Returns ClientInfoAndState for all victim-origin windows including their URLs

Root cause: aOriginContent is present in the API signature for all 5 operations but only OpenWindow actually uses it (via ClientOpenWindowUtils.cpp:492). MatchAll, Navigate, Claim, GetInfoAndState all ignore it.

C++ PoC compiled into debug build, activated by pref media.poc.victim_origin:

[ClientManagerPoC] MaybeRunClientManagerMatchAllPoC activated in content pid=52150 targeting origin=https://example.com
[ClientManagerPoC] EXPLOIT SUCCESS: 1 client(s) at origin=https://example.com leaked to attacker process
[ClientManagerPoC] url=https://example.com/

PoC source: dom/clients/manager/ClientManagerMatchAllPoC.cpp (hooked into ContentChild::InitXPCOM:1393)

Attachment #9571606 - Attachment is obsolete: true
Status: UNCONFIRMED → RESOLVED
Closed: 7 months ago
Duplicate of bug: 2018164
Resolution: --- → DUPLICATE
Group: core-security → dom-core-security
Group: dom-core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: