Closed
Bug 203345
Opened 21 years ago
Closed 21 years ago
Imagemaps need to be updated to properly check for XHTML docs
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.4beta
People
(Reporter: bzbarsky, Assigned: jst)
Details
(Keywords: regression, Whiteboard: [HAVE FIX])
Attachments
(2 files)
5.32 KB,
patch
|
hjtoi-bugzilla
:
review+
bzbarsky
:
superreview+
asa
:
approval1.4+
|
Details | Diff | Splinter Review |
278 bytes,
application/xhtml+xml
|
Details |
The code at http://lxr.mozilla.org/seamonkey/source/content/shared/src/nsImageMapUtils.cpp#87 seems to be semi-bogus now that bug 111514 has been fixed.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #121705 -
Flags: superreview?(bzbarsky)
Attachment #121705 -
Flags: review?(harishd)
Reporter | ||
Comment 2•21 years ago
|
||
Comment on attachment 121705 [details] [diff] [review] Proposed fix. Excellent. ;)
Attachment #121705 -
Flags: superreview?(bzbarsky) → superreview+
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla1.4beta
Comment on attachment 121705 [details] [diff] [review] Proposed fix. >Index: content/html/document/src/nsHTMLDocument.cpp >=================================================================== >- if (map && NS_SUCCEEDED(map->GetName(name))) { >- PRBool match; >+ NS_ASSERTION(map, "Null map in map list!"); We used to return NS_ERROR_FAILURE, with this change we would crash. Please make it so we return the error and won't crash if !map, and r=heikki.
Attachment #121705 -
Flags: review?(harishd) → review+
Assignee | ||
Comment 4•21 years ago
|
||
We won't hit the !map assertion unless someone breaks some code... mImageMaps is only filled with non-null nsIDOMHTMLMapElement pointers, strongly typed at compile time. There's no need to error check that, IMO. Let me know if you strongly disagree.
I can't say I strongly disagree, but if I can make something crash-proof I'd rather do it.
Assignee | ||
Comment 6•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
I'd like to get this on the 1.4 branch as well.
Keywords: nsbeta1
Updated•21 years ago
|
Attachment #121705 -
Flags: approval1.4?
Reopening to get this evaluated for the branch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•21 years ago
|
||
Comment on attachment 121705 [details] [diff] [review] Proposed fix. a=asa (on behalf of drivers) for checkin to the 1.4 branch.
Attachment #121705 -
Flags: approval1.4? → approval1.4+
Comment 11•21 years ago
|
||
a=adt to land this on the 1.4 branch. Please add the fixed1.4 keyword once this lands.
Assignee | ||
Comment 12•21 years ago
|
||
Fixed on the branch now too.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Keywords: fixed1.4
Resolution: --- → FIXED
Reporter | ||
Updated•21 years ago
|
Keywords: fixed1.4 → verified1.4
Reporter | ||
Comment 14•21 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•