203353 - drop down list in hebrew opens incorrectly aligned to the left of list control instead of right in rtl

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Noam]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312

(1) As can be seen on http://seret.co.il, on the first drop-down list at the top
right, the drop down list itself opens up incorrectly when clicking on the list.
 Instead of opening with the right-edges of the list aligned to the control, the
left-edges are aligned and this pushes larger text off the screen, and adds a
horizontal scroll bar at the bottom of the list.
(2) This makes it difficult to browse the list.  Pulling the scrollbar to the
right, to see the text, works correctly.  However, moving the mouse over the
text realigns the text itself incorrectly, and the scrollbar remains
right-aligned, even though the text is mismatched.

Note: it seems that the text inside the list is correctly aligned to beginwith.

Reproducible: Always

Steps to Reproduce:
1. browse to http://seret.co.il
2. click on the topmost dropdown list (1)
3. use the horizontal scrollbar, and move the mouse over the list alternatingly

Actual Results:  
(1) the list box is aligned incorrectly with the left edge of the control
(2) the the horizontal scrollbar incorrectly represents the horizontal position

Expected Results:  
the list box should be aligned to the right edge of the control.
the horizontal scrollbar should correctly represent the horizontal position at
all times.

I don't think this matters, but I'm using the Pinball theme, and I'm fairly
certain this happened before I started using this theme.  I use this site regularly.

Comment 1

[Simon Montagu :smontagu]

Attachment: Reduced test case with some different combinations

Comment 2

[Noam]

I believe this is related because of the testcases, but I can't be sure.

At the site http://www.dan.co.il, there are some more drop down lists.  In the
Hebrew version of the site, all the dropdowns have hebrew text and are displayed
incorrectly.  In the English and Russian versions of the site (see the En and Py
circles, respectively) the very same dropdowns display correctly.

I noticed that the select element has only a size=1 attribute, whereas the
options have no attributes.  I tried to create a testcase, but I couldn't
reproduce it, so I assume the bug is caused by some styles elsewhere.  I'll try
to pinpoint it later.

Should I open a new bug for this?

Comment 3

[Simon Montagu :smontagu]

Noam, if you mean the tiny fonts in the drop downs at www.dan.co.il, please open
a new bug

Comment 4

[Noam]

Submitted bug <a href="http://bugzilla.mozilla.org/show_bug.cgi?id=206041">Bug
#206041</a>.

Comment 5

[Jeff D. Hanson]

Confirmed:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030604

Comment 6

[Shoshannah Forbes]

per Comment #5 

Comment 7

[Uri Bernstein]

Seeing problems on Mac trunk. => All/All.

Comment 8

[Uri Bernstein]

Attachment: patch for aligning the drop-down

This patch deals only with the "easy" part of this bug: aligning the drop-down box to the left of the control, instead of to its right, in the RTL case.

The issues regarding alignment the options within the drop-down should be resolved in bug 348516.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 233458 [details] [diff] [review]
patch for aligning the drop-down

Nix the #ifdef and put braces around the if and else bodies.  sr=bzbarsky with that.

Comment 10

[Simon Montagu :smontagu]

Comment on attachment 233458 [details] [diff] [review]
patch for aligning the drop-down

... but you don't need the #ifdef IBMBIDI

Comment 11

[Uri Bernstein]

Comment on attachment 233458 [details] [diff] [review]
patch for aligning the drop-down

Restoring bz's sr+, which was lost in a mid-air collision.

Comment 12

[Uri Bernstein]

Attachment: Patch for aligning the drop-down v1.1 [checked in]

This is what I checked in (with the issues in comment #9 addressed).

Checking in layout/forms/nsComboboxControlFrame.cpp;
/cvsroot/mozilla/layout/forms/nsComboboxControlFrame.cpp,v  <--  nsComboboxControlFrame.cpp
new revision: 1.375; previous revision: 1.374
done

I'm leaving the bug open for the other issue, which would be fixed by the reflow branch.

Comment 13

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061208 Minefield/3.0a1 ID:2006120812 [cairo]

seems 99.99% fixed by reflow branch landing

what remains is a 1 px offset to the right for the RTL dropdown list, like for the LRT dropdown (also to the right)

Comment 14

[Uri Bernstein]

(In reply to comment #13)

> what remains is a 1 px offset to the right for the RTL dropdown list, like for
> the LRT dropdown (also to the right)

Could you please attach a screenshot for this? To me (on Mac) it seems like this might be simply due to the asymmetry of the 3D effects. I don't think there is a deliberate offsetting here.

Comment 15

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Comment 16

[Uri Bernstein]

Attachment: Screenshot from XP/Luna

Taken with 2006-12-18 build.

No problem here.

Comment 17

[Uri Bernstein]

Attachment: Screenshot from XP/Classic

Using the same build.

Surprisingly, this is different than Peter's screenshot. Although there does seem to be a 1px shift to the right with the RTL case, it's even less noticeable than in that screenshot.

To conclude: I think the remaining problem is very minor, and is specific to XP/Classic. So I'm going to close this bug as fixed. We could open a separate bug for the XP/Classic issue, in case anybody cares to investigate it.

Comment 18

[Peter van der Woude [:Peter6]]

I agree, that 1 pixel off-ish is not worth to keep this open

Comment 19

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).