2033531 - [wpt-sync] Sync PR 59314 - Extend context loss/restoration test coverage to desynchronized canvas

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 59314 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59314
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Extend context loss/restoration test coverage to desynchronized canvas

Desynchronize canvases use a resource dispatcher to push frames and
since the dispatcher is descarded on context loss [1], it's worth adding
test coverage for this.

Note that the frame dispatcher is never recreated after the context is
restored, so the canvas doesn't fully recover from the context loss. The
canvas can be read back though, so the tests still works and we can at
least validate that the context state transitions work properly.

Also note that the OffscreenCanvas doesn't do much with the
desynchronized flag, but the test coverage is still useful given that
this flag is listed as supported in MDN [1] and the specification [2].

[1] https://crsrc.org/c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=290;drc=8abea14deda089834ba142a35e8342014812df55
[2] https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvas/getContext
[3] https://html.spec.whatwg.org/multipage/canvas.html#canvas-setting-init-bitmap

Change-Id: I300d1f2827406120896cc7dc38794cb450ea3ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7770647
Reviewed-by: Vasiliy Telezhnikov \<[e-mail]>
Commit-Queue: Jean-Philippe Gravel \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1617254}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0560486b076954a1a5deeb0cd1f021b55f1eac6d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fae6cbb6cd09
https://hg.mozilla.org/integration/autoland/rev/10ce28e8ca00
[wpt PR 59314] - Extend context loss/restoration test coverage to desynchronized canvas, a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/10ce28e8ca00

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.