Closed Bug 2033595 Opened 6 months ago Closed 6 months ago

[Homepage Sports Widget] - Create middleware, lifecycle actions and SportsWidgetRepository interface

Categories

(Firefox for Android :: Homepage, task)

Product:
Firefox for Android
Component:
Homepage
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed
firefox152 --- fixed

People

(Reporter: skhan, Assigned: skhan)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(4 external files)

Create SportsMiddleware:

  • Implements Middleware<AppState, AppAction>
  • Fetches SportsRepository.fetchMatches on a click of reload button
  • Scheduled/pre-tournament: long interval (default 3 hours)
  • Dispatches SportsAction.MatchesUpdated with fresh data after each fetch

Add lifecycle actions to AppAction:

  • RefreshRequested Action
  • MatchesUpdated action

Create SportsWidgetRepository interface with fetchMatches method returning MatchCard result

Blocks: 2037227
No longer blocks: 2033589
Summary: [Homepage Sports Widget] - Create middleware, lifecycle actions, and Nimbus feature config → [Homepage Sports Widget] - Create middleware, lifecycle actions
Blocks: 2037222
No longer blocks: 2037227
Summary: [Homepage Sports Widget] - Create middleware, lifecycle actions → [Homepage Sports Widget] - Create middleware, lifecycle actions and SportsWidgetRepository interface
Assignee: nobody → skhan
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group3][world-cup-phase2]
Pushed by skhan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/948b29f8b5cd https://hg.mozilla.org/integration/autoland/rev/aa4690d17891 Create SportsMiddleware, SportRepository and add lifecycle actions r=android-reviewers,moyin

https://hg.mozilla.org/mozilla-central/rev/aa4690d17891

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Attachment #9591743 - Attachment description: WIP: Bug 2033595 - Create SportsMiddleware, SportRepository and add lifecycle actions → Bug 2033595 - Create SportsMiddleware, SportRepository and add lifecycle actions
Attachment #9591743 - Flags: approval-mozilla-release+

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: