Closed Bug 2033599 Opened 6 months ago Closed 6 months ago

[Homepage Sports Widget] - Real World Cup API integration

Categories

(Firefox for Android :: Homepage, task)

All
Android
task

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox151 --- fixed
firefox152 --- fixed

People

(Reporter: skhan, Assigned: skhan)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(8 external files)

To be done last. Depends on everything

Create WorldCupApiRepository : SportsWidgetRepository backed by the real endpoint:

  • Maps API response fields to SportsMatch / MatchStatus / TournamentPhase by using the mapper in bug 2037227
  • Handles UTC timestamp → local timezone conversion
  • Handles team logo URLs
  • Handles match stage/round name

Replace MockSportsRepository with WorldCupApiRepository in Components.kt (behind the Nimbus enabled flag or a build-config gate). Keep MockSportsRepository for tests and UI previews.

Blocks: 2037222
No longer blocks: 2033589
Whiteboard: [fxdroid][group3][world-cup-phase2]
Assignee: nobody → skhan
Attachment #9586256 - Attachment description: WIP: Bug 2033599 - Add WorldCupMatchesRepository backed by app-services WorldCupClient → Bug 2033599 - Add WorldCupMatchesRepository backed by app-services WorldCupClient
Status: NEW → ASSIGNED
Blocks: 2039769
Pushed by skhan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d951f09a2a48 https://hg.mozilla.org/integration/autoland/rev/b3173c343e71 Add WorldCupMatchesRepository backed by app-services WorldCupClient r=android-reviewers,moyin https://github.com/mozilla-firefox/firefox/commit/f7da8d66eb10 https://hg.mozilla.org/integration/autoland/rev/79718bc04e51 Wire SportsWidgetMiddleware into AppStore with WorldCupMatchesRepository r=android-reviewers,moyin
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Blocks: 2040711
Attachment #9591754 - Attachment description: WIP: Bug 2033599 - Wire SportsWidgetMiddleware into AppStore with WorldCupMatchesRepository → Bug 2033599 - Wire SportsWidgetMiddleware into AppStore with WorldCupMatchesRepository
Attachment #9591753 - Attachment description: WIP: Bug 2033599 - Add WorldCupMatchesRepository backed by app-services WorldCupClient → Bug 2033599 - Add WorldCupMatchesRepository backed by app-services WorldCupClient
Attachment #9591754 - Flags: approval-mozilla-release+
Attachment #9591753 - Flags: approval-mozilla-release+

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: