203399 - remove needless stylesheet editor call

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Kathleen :Brade]

The core editor already adds this stylesheet as a resource url.
The JS code should be removed.

Comment 1

[Kathleen :Brade]

Attachment: remove needless code

Comment 2

[timeless]

Comment on attachment 121728 [details] [diff] [review]
remove needless code

for my sanity, the code to which brade refers is:
/editor/libeditor/html/nsHTMLEditor.cpp, line 337 --
AddOverrideStyleSheet(NS_LITERAL_STRING("resource:/res/EditorOverride.css"));

this isn't technically the same as
const kBaseEditorStyleSheet = "chrome://editor/content/EditorOverride.css";

but the spirit is. you can also kill the jar.mn line:
/editor/ui/jar.mn, line 17 -- content/editor/EditorOverride.css
(composer/content/EditorOverride.css)

Comment 3

[Kathleen :Brade]

Attachment: missing piece for packaging

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 122012 [details] [diff] [review]
missing piece for packaging

r=glazman

Comment 5

[Alec Flett]

you need to be getting driver approval for this stuff.

Comment 6

[Kathleen :Brade]

Yes, I sent e-mail to drivers after I realized my error (shortly after checking in).

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 121728 [details] [diff] [review]
remove needless code

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 122012 [details] [diff] [review]
missing piece for packaging

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 9

[Kathleen :Brade]

fix checked in

Comment 10

[Chris Petersen]

Verified in the 2003-05-01-03 Macho and 2003-05-01-08 win32 trunk builds.