New search bar has no local suggestion autocomplete when remote suggestions are turned off
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox-esr153 | --- | fixed |
| firefox155 | --- | fixed |
People
(Reporter: mail, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(4 files, 2 external files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:150.0) Gecko/20100101 Firefox/150.0
Steps to reproduce:
When browser.search.widget.new=true, the search bar has no autocomplete. Writing in it doesn't populate the dropdown with matches from previous searches.
When browser.search.widget.new=false, this works as expected. Writing populates the dropdown.
Actual results:
The dropdown was not populated.
Expected results:
The dropdown should have been populated with prior searches.
| Reporter | ||
Comment 1•6 months ago
|
||
| Reporter | ||
Comment 2•6 months ago
|
||
Comment 3•6 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Updated•6 months ago
|
Comment 4•6 months ago
|
||
Moritz, did the changes we make to displaying history mean that we would expect this? Or could this be a setting that we're now respecting in 150?
Comment 5•6 months ago
|
||
This is not expected and I think your suspicion is correct. Setting browser.urlbar.maxHistoricalSearchSuggestions=0 for example could cause this.
Tino, could you please attach a report from about:support? That allows us to see your value of browser.urlbar.maxHistoricalSearchSuggestions and other prefs that could be relevant.
| Reporter | ||
Comment 6•6 months ago
|
||
| Assignee | ||
Updated•6 months ago
|
Updated•6 months ago
|
| Reporter | ||
Comment 7•6 months ago
|
||
about:support doesn't mention browser.urlbar.maxHistoricalSearchSuggestions, so here's a screenshot of about:config's results for that.
I should mention this is a Firefox profile inherited through the ages. It was created under Phoenix. There are files in the profile folder from 2005-11-12. Surprisingly well behaved with the continuous upgrades for over 20 years.
| Assignee | ||
Updated•6 months ago
|
Comment 8•6 months ago
|
||
Thank you. Looks like this is due to the browser.search.suggest.enabled pref. In the searchbar code, it only controls remote suggestions, but in the urlbar code, it controls both remote and local suggestions. Since the new searchbar is based on the urlbar code, you are not getting local suggestions anymore.
This is certainly quite confusing, so I will discuss with the team if we should make the pref work in the new searchbar like it did in the old searchbar.
Updated•6 months ago
|
| Assignee | ||
Comment 9•3 months ago
|
||
browser.search.suggest.enabled turns off remote search suggestions. The
old search bar kept showing form history when it was off; the new one,
built on urlbar code, adopted the urlbar's stricter reading of the pref
and suppressed form history too.
The behavior change is scoped to the searchbar SAP, so the urlbar (where
the pref does gate both kinds of suggestion) is unaffected: check the two
pref reads that moved out of _allowSuggestions and into the remote-only
gate, and note that _allowSuggestions now returns early only for the
urlbar's own suggest.searches pref.
This also restores form history in private windows, where
browser.search.suggest.enabled.private defaults to false and was
suppressing the search bar's suggestions entirely.
Updated•3 months ago
|
Comment 10•3 months ago
|
||
Comment 11•3 months ago
|
||
| bugherder | ||
Updated•3 months ago
|
Updated•3 months ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Updated•12 days ago
|
| Assignee | ||
Comment 13•12 days ago
|
||
browser.search.suggest.enabled turns off remote search suggestions. The
old search bar kept showing form history when it was off; the new one,
built on urlbar code, adopted the urlbar's stricter reading of the pref
and suppressed form history too.
The behavior change is scoped to the searchbar SAP, so the urlbar (where
the pref does gate both kinds of suggestion) is unaffected. Remote
suggestions stay off in the search bar as well, since
SearchSuggestionController checks the pref itself before fetching them.
This also restores form history in private windows, where
browser.search.suggest.enabled.private defaults to false and was
suppressing the search bar's suggestions entirely.
Original Revision: https://phabricator.services.mozilla.com/D316300
Updated•12 days ago
|
Comment 14•12 days ago
|
||
firefox-esr153 Uplift Approval Request
- User impact if declined/Reason for urgency: With "Show search suggestions" turned off, the search bar stops showing matching search history as you type (bug 2087821, regressed by bug 2006632). In private windows the search bar shows no form history by default.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: no
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: See bug 2087821 comment 0
- Risk associated with taking this patch: low
- Explanation of risk level: The change makes one existing condition skip the search bar; the address bar's behavior is unchanged. Remote suggestions stay off in the search bar because SearchSuggestionController checks the pref itself.
- String changes made/needed?: none
- Is Android affected?: no
Updated•7 days ago
|
Updated•7 days ago
|
Comment 15•7 days ago
|
||
| uplift | ||
Description
•