Closed Bug 2034059 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 59377 - script: Achieve failure parity with other browsers for underline command

Categories

(Core :: DOM: Editor, task, P4)

Product:
Core
Component:
DOM: Editor
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Notable wpt changes
551.88 KB, text/plain
Details

Sync web-platform-tests PR 59377 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59377
Details from upstream follow.

Tim van der Lippe <tvanderlippe@gmail.com> wrote:

script: Achieve failure parity with other browsers for underline command

With these changes, we now fail the minimum set of tests. That is to say: we don't fail any test that no other browser fails. All test failures therefore match at least 1 other browser.

The one exception is the updated test expectation. That's because all browsers fail this test in the exact same way, hence updating the expectation. We fail it, since I don't know how browsers reach to that point. I think it's related to traversal of the contained children and the order that they are traversed in. Unfortunately my attempts at fixing that have not been fruitful, so leaving that one for now.

Part of #<!-- nolink -->25005

Testing: WPT
Reviewed in servo/servo#44390

Component: web-platform-tests → DOM: Editor
Product: Testing → Core
Attached file Notable wpt changes —

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 120 tests and 395 subtests

Status Summary

Firefox

OK : 3[GitHub] 119[Gecko-windows11-32-25h2-debug] 120[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 2106[GitHub] 92078[Gecko-windows11-32-25h2-debug] 93037[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 41[GitHub] 3663[Gecko-windows11-32-25h2-debug] 3704[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 3
PASS: 1780
FAIL: 367

Safari

OK : 3
PASS: 1792
FAIL: 355

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /editing/run/underline.html?1-1000 [wpt.fyi]
    • [["stylewithcss","true"],["underline",""]] "<span>[foo</span> <span>bar]</span>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "<span>[foo</span> <span>bar]</span>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","true"],["underline",""]] "<p>[foo</p><p> <span>bar</span> </p><p>baz]</p>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "<p>[foo</p><p> <span>bar</span> </p><p>baz]</p>" queryCommandIndeterm("underline") before: FAIL
    • [["underline",""]] "<span>foo[</span><span>]bar</span>" queryCommandState("underline") after: FAIL
    • [["stylewithcss","true"],["underline",""]] "<table><tbody data-start=0 data-end=1><tr><td>foo<td>bar<td>baz</table>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "<table><tbody data-start=0 data-end=1><tr><td>foo<td>bar<td>baz</table>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","true"],["underline",""]] "<table data-start=0 data-end=1><tbody><tr><td>foo<td>bar<td>baz</table>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "<table data-start=0 data-end=1><tbody><tr><td>foo<td>bar<td>baz</table>" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","true"],["underline",""]] "{<table><tr><td>foo<td>bar<td>baz</table>}" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "{<table><tr><td>foo<td>bar<td>baz</table>}" queryCommandIndeterm("underline") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "<u>foo[b<span style="color:blue">ar]ba</span>z</u>" compare innerHTML: FAIL
    • [["stylewithcss","false"],["underline",""]] "<u>foo[b<span style="color:blue" id=foo>ar]ba</span>z</u>" compare innerHTML: FAIL
    • [["stylewithcss","false"],["underline",""]] "<u>foo[b<span style="font-size:3em">ar]ba</span>z</u>" compare innerHTML: FAIL
    • [["stylewithcss","true"],["underline",""]] "<p style="text-decoration: underline">foo[bar]baz</p>" queryCommandState("underline") after: FAIL
    • [["stylewithcss","false"],["underline",""]] "<p style="text-decoration: underline">foo[bar]baz</p>" queryCommandState("underline") after: FAIL
  • /editing/run/underline.html?2001-last [wpt.fyi]
    • [["stylewithcss","false"],["underline",""]] "foo<u>[bar]</u>baz" queryCommandState("stylewithcss") before: FAIL
    • [["stylewithcss","false"],["underline",""]] "{ <span contenteditable="false">A</span> ; <span contenteditable="false">B</span> ; <span contenteditable="false">C</span> }" compare innerHTML: FAIL

(See attachment for full changes)

https://hg.mozilla.org/mozilla-central/rev/c29f56c484b4
https://hg.mozilla.org/mozilla-central/rev/6756402d44c6

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: