2034104 - Ship Iterator Includes proposal

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[Dan Minor [:dminor]]

Once the proposal reaches Stage 3, we can ship it. As part of the implementation work, we landed tests in a pr (https://phabricator.services.mozilla.com/D295351), we should remove those tests when we reimport test262 prior to shipping.

Comment 1

[Dan Minor [:dminor]]

Planning this for 154.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 2034104 - Update Test262 tests for iterator includes; r=#spidermonkey-reviewers!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 2034104 - Update implementation for spec changes; r=#spidermonkey-reviewers!

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 2034104 - Ship Iterator Includes; r=#spidermonkey-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/92a1856375e0
https://hg.mozilla.org/integration/autoland/rev/39fce5be51c3
Update Test262 tests for iterator includes; r=spidermonkey-reviewers,anba
https://github.com/mozilla-firefox/firefox/commit/942af34736ef
https://hg.mozilla.org/integration/autoland/rev/84d89afd34d6
Update implementation for spec changes; r=spidermonkey-reviewers,anba
https://github.com/mozilla-firefox/firefox/commit/c89d70946af0
https://hg.mozilla.org/integration/autoland/rev/74afd6b962e6
Ship Iterator Includes; r=spidermonkey-reviewers,anba

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/39fce5be51c3
https://hg.mozilla.org/mozilla-central/rev/84d89afd34d6
https://hg.mozilla.org/mozilla-central/rev/74afd6b962e6

Comment 7

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Ships Iterator.prototype.includes
[Affects Firefox for Android]: Yes
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/includes

Comment 8

[Dianna Smith [:diannaS]]

Added to 154 release notes

Firefox now supports Iterator.prototype.includes(), allowing developers to check whether an iterator contains a given value without first converting it to an array.

Comment 9

[Hamish Willee]

FF154 MDN work for this can be tracked in https://github.com/mdn/content/issues/44838. Essentially just an MDN release note and compatibility data.