Closed Bug 2034119 Opened 6 months ago Closed 6 months ago

Backport important libwebrtc fixes for Fx151

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 + fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

(Keywords: csectype-bounds, sec-high, Whiteboard: [adv-main151+r])

Attachments

(1 external file)

We'll use this to hang libwebrtc patches for Fx151.

Attached file (secure) —

Upstream commit: https://webrtc.googlesource.com/src/+/997079137283f693a0fac6a5350ae7f6f2cf3b59
[M147] Check vector sizes when crossfading from CNG/expand to normal.

Original change's description:
> Check vector sizes when crossfading from CNG/expand to normal.
>
> This fixes a potential out-of-bounds write.
>
> Bug: chromium:502661101
> Change-Id: I6f03b522643d7a55040d7f5403f342b32d47f0c7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/464500
> Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#47447}

(cherry picked from commit ff1be2e8524fe63069fc2406d5e3f3ddccafee1a)

Bug: chromium:504499897,chromium:502661101
Change-Id: I6f03b522643d7a55040d7f5403f342b32d47f0c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/465260
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7727@{#11}
Cr-Branched-From: 5788235ac856f62f1522d1491c4a8b00dba10c82-refs/heads/main@{#47086}

:mjf, is the plan to add an uplift request to this patch for beta (Fx151)?
I'm not sure how ESR115 and ESR140 ffixes are tracked for Bug 2030044?

Flags: needinfo?(mfroman)

Yes, for sure Fx151. The patch was reviewed today. I'll request the uplift asap.

Flags: needinfo?(mfroman)

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: This is a patch uplifted in upstream libwebrtc, and is a known important sec fixe.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: These are already in upstream libwebrtc.
  • String changes made/needed?: n/a
  • Is Android affected?: yes
Attachment #9572529 - Flags: approval-mozilla-beta?
Attachment #9572529 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Group: media-core-security → core-security-release
QA Whiteboard: [sec] [qa-triage-done-c152/b151]
Whiteboard: [adv-main151+r][adv-esr115.36+r][adv-esr140.11+r]
Whiteboard: [adv-main151+r][adv-esr115.36+r][adv-esr140.11+r] → [adv-main151+r]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: