2034183 - browser/components/preferences/tests/head.js pulled into search preferences test twice, leading to test failure

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Stephanie Cunnane [:scunnane]]

I'm currently seeing a test failure for browser/components/preferences/tests/search/browser_search_firefoxSuggest.js on main, where the test is unable to get at a function defined in the head file. Commenting out this line fixes the problem, as we're already importing head.js from the parent directory here.

This seems like a regression caused by bug 2026772, but I may be missing something here?

Comment 1

[BugBot [:suhaib / :marco]]

:florian, since you are the author of the regressor, bug 2026772, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2026772

Comment 3

[Stephanie Cunnane [:scunnane]]

Update: as of this morning, I'm no longer seeing failures in browser/components/preferences/tests/search/browser_search_firefoxSuggest.js on the current main. So I'm closing this bug as INVALID.

But I'm still unclear as to why that test seemingly imports the parent head file twice.

Comment 4

[Stephanie Cunnane [:scunnane]]

Reopening this bug, as I'm seeing browser/components/preferences/tests/search/browser_search_firefoxSuggest.js failing again on the current main.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Florian, can you maybe provide some pointers for where to investigate this? Thanks!

Comment 6

[Florian Quèze [:florian]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Florian, can you maybe provide some pointers for where to investigate this? Thanks!

Unfortunately I don't understand this bug, steps to reproduce would be helpful. browser_search_firefoxSuggest.js is 100% green in CI: https://tests.firefox.dev/test.html?test=browser%2Fcomponents%2Fpreferences%2Ftests%2Fsearch%2Fbrowser_search_firefoxSuggest.js

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Stephanie, maybe you can provide some clarification for where you're seeing this? This bug seems pretty stuck at the moment.

Comment 8

[Stephanie Cunnane [:scunnane]]

Actually I am no longer seeing any test failures in browser/components/preferences/tests/search/browser_search_firefoxSuggest.js, so I will just close the bug.