2034253 - Investigate how to support per-task rebuild counts in mach try perf

Status: RESOLVED FIXED

(Testing :: Performance, enhancement, P3)

Description

[Kash Shampur [:kshampur] ⌚EST]

--rebuild currently applies uniformly to all tasks in a try push. We want per-task counts so e.g. Speedometer 3 in "Critical Android Performance" gets 10 retriggers while jetstream/applink-startup get 1.

or in critical desktop (which currently only has speedometer3) we may want different tests with different retriggers amounts as that category grows.

Or if people mix categories, that would also have different rebuilds (defaults to 1 right now if someone chose critical desktop + something else)

AFAIK the need for this kind of feature is kind of specific to mach try perf, but changes may be needed mainly in taskgraph. This bug is just to investigate what is needed for this

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

hm this seems to work.
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=d340863a026df73c58c940df4f624ef44cfc377a

for testing i gave sp3 6 rebuilts and jetstream3, 3 rebuilds as a default in critical desktop category
and i currently see that amount being applied

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

i'll squash my changes and put up a WIP patch soon ish

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 2034253 - Support per-task rebuild counts in mach try perf r?#perftest

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6cfe8ced2bf5
https://hg.mozilla.org/integration/autoland/rev/58c19b1ae0f0
Support per-task rebuild counts in mach try perf r=perftest-reviewers,taskgraph-reviewers,sparky,ahal

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0102707d0b75
https://hg.mozilla.org/integration/autoland/rev/e07cba519267
Revert "Bug 2034253 - Support per-task rebuild counts in mach try perf r=perftest-reviewers,taskgraph-reviewers,sparky,ahal" for causing python-taskgraph tests failures on test_morph.py.

Comment 6

[Iulian Moraru]

Revert for causing python-taskgraph tests failures on test_morph.py.

• Push with failures

• Failure log

• Backout link

Comment 7

[Kash Shampur [:kshampur] ⌚EST]

fixed the test failure
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=ae1be9e0e4e8f41853f95c8b9dd7597c900fa975&selectedTaskRun=aGs5QA_HSOWJZbX9Wp7zmg.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8e53b0e1b397
https://hg.mozilla.org/integration/autoland/rev/bea97e9ea397
Support per-task rebuild counts in mach try perf r=perftest-reviewers,taskgraph-reviewers,sparky,ahal

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bea97e9ea397