Closed Bug 2034397 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 59436 - Fix progress() internal type

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Notable wpt changes
619.78 KB, text/plain
Details

Sync web-platform-tests PR 59436 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59436
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

Fix progress() internal type

progress() always return number, but while creating
CalculationExpressionNode the result was saved as pixels and percents,
which later confused our type system.

Fixed: 504004119
Change-Id: I50e7090f63a678e147d99fad8e089aad4b6425fa
Reviewed-on: https://chromium-review.googlesource.com/7789613
WPT-Export-Revision: b0ef926a182d2ed6f3ad406b46f55392c2339bbe

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Attached file Notable wpt changes —

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 437 tests

Status Summary

Firefox

OK : 1[GitHub] 234[Gecko-linux2404-64-debug] 235[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 20[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 5266[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 5400[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 5411[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL: 23[GitHub] 4327[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 4362[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 4375[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 1
PASS: 23

Safari

OK : 1
PASS: 22
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-values/progress-computed.html [wpt.fyi]
    • progress(1, 0, 1) should be used-value-equivalent to 1: FAIL linked bug:Bug 1973067
    • progress(progress(1, 0, 1), progress(0px, 0px, 1px), progress(1deg, 0deg, 1deg)) should be used-value-equivalent to 1: FAIL linked bug:Bug 1973067
    • progress(sign(-10px) * 10px, (10px - 10px), 10px * progress(1deg, 0deg, 1deg)) should be used-value-equivalent to 0: FAIL
    • calc(progress(100px, 0px, 50px) * 10px + 100px) should be used-value-equivalent to 110px: FAIL
    • calc(progress(100, 0, sign(50px))) should be used-value-equivalent to 1: FAIL
    • calc(progress(abs(5%), hypot(3%, 4%), 10%)) should be used-value-equivalent to 0: FAIL linked bug:Bug 1973067
    • progress(50em, 10em, 110em) should be used-value-equivalent to 0.4: FAIL linked bug:Bug 1973067
    • progress(1000em, 10em, 110em) should be used-value-equivalent to 1: FAIL
    • scale(progress(50em, 10rem, 110em)) should be used-value-equivalent to scale(1): FAIL linked bug:Bug 1973067
    • scale(progress(1000em, 10rem, 110em)) should be used-value-equivalent to scale(1): FAIL
    • scale(progress(0em, 0rem, 0em)) should be used-value-equivalent to scale(0): FAIL linked bug:Bug 1973067
    • scale(progress(sign(1em - 1rem) * 1ex, 0rem, 0em)) should be used-value-equivalent to scale(0): FAIL linked bug:Bug 1973067
    • calc(progress(1, 0, 1) * 10px) should be used-value-equivalent to 10px: FAIL linked bug:Bug 1973067
    • calc(progress(1, 0, 1) * 1s) should be used-value-equivalent to 1s: FAIL linked bug:Bug 1973067
    • calc(progress(1, 0, 1) * 1deg) should be used-value-equivalent to 1deg: FAIL linked bug:Bug 1973067
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 10em, 2rem, 12em) / 2) should be used-value-equivalent to 0.4: FAIL linked bug:Bug 1973067
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 20em, 2rem, 12em) * 10) should be used-value-equivalent to 10: FAIL
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 20em, 2rem, 12em) * 30) should be used-value-equivalent to 30: FAIL
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 20em, 2rem, 12em) / 4) should be used-value-equivalent to 0.25: FAIL
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 20em, 2rem, 12em) * 4) should be used-value-equivalent to 4: FAIL
    • calc(progress(sign(1001em - 10lh * progress(100px, 2rex, 10ex)) * 20em, 2rem, 12em) * 2) should be used-value-equivalent to 2: FAIL
    • rotate3d(progress(21em, 1rem, 11em), progress(21em, 1rem, 11em), progress(21em, 1rem, 11em), calc(progress(11em, 1rem, 11em) * 2deg)) should be used-value-equivalent to rotate3d(2, 2, 2, 2deg): FAIL linked bug:Bug 1973067

(See attachment for full changes)

https://hg.mozilla.org/mozilla-central/rev/42bc4057d68a
https://hg.mozilla.org/mozilla-central/rev/6c902f303156

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: