Closed Bug 2034495 Opened 23 days ago Closed 11 days ago

Audit/rename toolbar tokens

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: jooliver, Assigned: jooliver)

References

Details

(Whiteboard: [recomp][acorntractors])

Attachments

(1 file)

Bug 2034495 - rename toolbar tokens r=#desktop-theme-reviewers
48 bytes, text/x-phabricator-request
Details

Toolbar tokens were converted to json in Bug 2017970, but token naming was left as-is due to potential ripple effects. Audit and update toolbar, toolbarbutton, toolbarseparator and toolbox token names to ensure consistency with the naming structures of other existing tokens. Update existing usage of renamed tokens.

Examples:

  • --toolbar-bgcolor should be --toolbar-background-color
  • --toolbox-bgcolor should be --toolbox-background-color
Whiteboard: [recomp][acorntractors]
Assignee: nobody → jooliver
Status: NEW → ASSIGNED
  • renames toolbar, toolbarbutton, toolbox tokens for consistent formatting with other design tokens
  • updates usage of renamed css tokens
Attachment #9574150 - Attachment description: WIP: Bug 2034495 - rename toolbar tokens → Bug 2034495 - rename toolbar tokens r=#desktop-theme-reviewers
Pushed by jooliver@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f7f61baab555 https://hg.mozilla.org/integration/autoland/rev/7c1502f20720 rename toolbar tokens r=desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,profiles-reviewers,hjones,sfoster,dao,mossop

https://hg.mozilla.org/mozilla-central/rev/7c1502f20720

Status: ASSIGNED → RESOLVED
Closed: 11 days ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Regressions: 2038983
Regressions: 2037872
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: