Closed
Bug 2034495
Opened 4 months ago
Closed 4 months ago
Audit/rename toolbar tokens
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
152 Branch
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: jooliver, Assigned: jooliver)
References
Details
(Whiteboard: [recomp][acorntractors])
Attachments
(1 file)
Toolbar tokens were converted to json in Bug 2017970, but token naming was left as-is due to potential ripple effects. Audit and update toolbar, toolbarbutton, toolbarseparator and toolbox token names to ensure consistency with the naming structures of other existing tokens. Update existing usage of renamed tokens.
Examples:
--toolbar-bgcolorshould be--toolbar-background-color--toolbox-bgcolorshould be--toolbox-background-color
|
Assignee | |
Updated•4 months ago
|
Whiteboard: [recomp][acorntractors]
|
||
Updated•4 months ago
|
|
|
Assignee | |
Updated•4 months ago
|
Assignee: nobody → jooliver
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•4 months ago
|
||
- renames toolbar, toolbarbutton, toolbox tokens for consistent formatting with other design tokens
- updates usage of renamed css tokens
|
||
Updated•4 months ago
|
Attachment #9574150 -
Attachment description: WIP: Bug 2034495 - rename toolbar tokens → Bug 2034495 - rename toolbar tokens r=#desktop-theme-reviewers
Pushed by jooliver@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f7f61baab555
https://hg.mozilla.org/integration/autoland/rev/7c1502f20720
rename toolbar tokens r=desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,profiles-reviewers,hjones,sfoster,dao,mossop
|
||
Comment 3•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox152:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
|
||
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in
before you can comment on or make changes to this bug.
Description
•