2034507 - Simplify search mode switcher item activation in tests

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Moritz Beier [:mbeier]]

There are many cases similar to

let popup = await UrlbarTestUtils.openSearchModeSwitcher(window);
let popupHidden = UrlbarTestUtils.searchModeSwitcherPopupClosed(window);
popup.querySelector("panel-item[data-engine-id=engine1]").button.click();
await popupHidden;

throughout the urlbar test code. We could make it possible to use .click() instead of .button.click() and introduce a helper that can do those 4 lines in one call to simplify the code a bit.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 2034507 - Part 2: Simplify search mode switcher item activation in tests. r?#urlbar-reviewers

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2034507 - Part 1: Wait for addon page options to become active before clicking in tests. r?robwu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e879bffb415
https://hg.mozilla.org/integration/autoland/rev/c8dcd33eb5eb
Part 1: Wait for addon page options to become active before clicking in tests. r=robwu
https://github.com/mozilla-firefox/firefox/commit/cb5e8e8f09a2
https://hg.mozilla.org/integration/autoland/rev/0a105ae0e10e
Part 2: Simplify search mode switcher item activation in tests. r=urlbar-reviewers,extension-reviewers,akulyk,dao,robwu

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c8dcd33eb5eb
https://hg.mozilla.org/mozilla-central/rev/0a105ae0e10e