Closed Bug 2034523 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 59401 - Wire up URL request modifiers for @import url()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

152 Branch

Tracking Flags:

Tracking

Status

firefox152

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

1 month ago

Sync web-platform-tests PR 59401 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59401
Details from upstream follow.

jj <jj@imput.net> wrote:

Wire up URL request modifiers for @import url()

Parse cross-origin(), integrity(), and referrer-policy() modifiers on
@import url() rules, apply them to the stylesheet fetch (CORS mode,
integrity metadata, referrer policy), and serialize them back in
CSSImportRule::cssText().

Bug: 435625756
Change-Id: I4f52b9dce9871593005595fac9ac3e661e2af65b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7779724
Commit-Queue: jj \<jj@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1619475}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

1 month ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e7f92dc91b3e8e57a3c8ca19165f8e4e013a5da

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

1 month ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 34 tests

Status Summary

Firefox

OK : 3[GitHub] 10[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 6[GitHub] 51[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 55[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 10[GitHub] 52[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 72[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

OK : 3
PASS: 6
FAIL: 10

Safari

OK : 3
PASS: 6
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-values/urls/referrer-policy/no-referrer/url-import-referrer-policy.html [wpt.fyi]
- referrer-policy(no-referrer) sends no referrer for @import: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/urls/url-request-modifiers-computed.sub.html [wpt.fyi]
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" cross-origin(anonymous))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" cross-origin(use-credentials))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" integrity("sha384-foobar"))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" integrity(""))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer-when-downgrade))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(same-origin))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(origin))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(strict-origin))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(origin-when-cross-origin))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(strict-origin-when-cross-origin))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(unsafe-url))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" cross-origin(anonymous) integrity("sha384-foobar"))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" integrity("sha384-foobar") cross-origin(anonymous))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" integrity("sha384-foobar") referrer-policy(no-referrer))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer) integrity("sha384-foobar"))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" cross-origin(anonymous) referrer-policy(no-referrer))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer) cross-origin(anonymous))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" cross-origin(anonymous) integrity("sha384-foobar") referrer-policy(no-referrer))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" integrity("sha384-foobar") referrer-policy(no-referrer) cross-origin(anonymous))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer) cross-origin(anonymous) integrity("sha384-foobar"))': FAIL
- Property background-image value 'url("http://web-platform.test:8000/css/support/1x1-green.png" referrer-policy(no-referrer) integrity("sha384-foobar") cross-origin(anonymous))': FAIL
/css/css-values/urls/url-request-modifiers-import-parsing.sub.html [wpt.fyi]
- cross-origin(anonymous) in @import: FAIL (Chrome: FAIL, Safari: FAIL)
- referrer-policy(no-referrer) in @import: FAIL (Chrome: FAIL, Safari: FAIL)
- integrity() in @import: FAIL (Chrome: FAIL, Safari: FAIL)
- multiple modifiers in @import: FAIL (Chrome: FAIL, Safari: FAIL)
- all three modifiers in @import: FAIL (Chrome: FAIL, Safari: FAIL)
- cross-origin(anonymous) serialized in @import cssText: FAIL (Chrome: FAIL, Safari: FAIL)
- multiple modifiers serialized in canonical order in @import cssText: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/urls/url-request-modifiers-serialize.sub.html [wpt.fyi]
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" cross-origin(anonymous))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" cross-origin(use-credentials))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" integrity("sha384-foobar"))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" integrity(""))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer-when-downgrade))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(same-origin))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(origin))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(strict-origin))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(origin-when-cross-origin))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(strict-origin-when-cross-origin))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(unsafe-url))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" cross-origin(anonymous) integrity("sha384-foobar"))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" integrity("sha384-foobar") cross-origin(anonymous))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" integrity("sha384-foobar") referrer-policy(no-referrer))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer) integrity("sha384-foobar"))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" cross-origin(anonymous) referrer-policy(no-referrer))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer) cross-origin(anonymous))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" cross-origin(anonymous) integrity("sha384-foobar") referrer-policy(no-referrer))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" integrity("sha384-foobar") referrer-policy(no-referrer) cross-origin(anonymous))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer) cross-origin(anonymous) integrity("sha384-foobar"))" should set the property value: FAIL
- e.style['background-image'] = "url("http://web-platform.test:8000/css/support/1x1-green.png\" referrer-policy(no-referrer) integrity("sha384-foobar") cross-origin(anonymous))" should set the property value: FAIL
/css/css-values/urls/cross-origin/url-image-cross-origin-anonymous.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/cross-origin/url-image-cross-origin-use-credentials.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/cross-origin/url-import-cross-origin-anonymous.sub.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/urls/integrity/url-import-integrity.sub.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/urls/referrer-policy/no-referrer/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/no-referrer/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/no-referrer-when-downgrade/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/no-referrer-when-downgrade/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/origin/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/origin/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/origin-when-cross-origin/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/origin-when-cross-origin/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/same-origin/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/same-origin/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/strict-origin/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/strict-origin/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/strict-origin-when-cross-origin/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/strict-origin-when-cross-origin/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/unsafe-url/url-image-referrer-policy-cross-origin.sub.html [wpt.fyi]: FAIL
/css/css-values/urls/referrer-policy/unsafe-url/url-image-referrer-policy-same-origin.sub.html [wpt.fyi]: FAIL

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

1 month ago

Depends on: 2034793

Pulsebot

Comment 3

•

1 month ago

Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bc6fab82fd61 https://hg.mozilla.org/mozilla-central/rev/285b32174a74 [wpt PR 59401] - Wire up URL request modifiers for @import url(), a=testonly https://github.com/mozilla-firefox/firefox/commit/7dc9716c7600 https://hg.mozilla.org/mozilla-central/rev/2e8d1dde7136 [wpt PR 59401] - Update wpt metadata, a=testonly

amarc

Comment 4

•

1 month ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/285b32174a74
https://hg.mozilla.org/mozilla-central/rev/2e8d1dde7136

Status: NEW → RESOLVED

Closed: 1 month ago

status-firefox152: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 152 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 59401 - Wire up URL request modifiers for @import url()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 3

Comment 4