2034921 - Re-enable smart cursor and integrate with Smart Window

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Justin Levinsohn]

Re-enable smart cursor and ensure it works within Smart Window using the native sidebar and chat experience.

• Smart cursor is enabled under pref browser.ml.chat.shortcuts
• Highlighting text on a webpage surfaces the smart cursor affordance
• Right-click "Ask AI" entry triggers the same Smart Window flow
• Behavior matches Classic implementation, adapted to Smart Window UI

Flow 1: Assistant closed

• Triggering smart cursor opens the Smart Window sidebar
• Selected text is passed into the assistant
• User is prompted with actions (e.g. Summarize, Explain this, Quiz me)
• Selecting an action creates a prompt in the Smart Window chat

Flow 2: Assistant open

• Triggering smart cursor does not reopen sidebar
• Selected text is added to the existing Smart Window chat
• Suggested actions (Summarize, Explain, etc.) are shown inline
• Selecting an action appends to the current conversation
• Smart cursor interaction takes priority over natural language request input when triggered
• Selected text is accurately captured and passed to the assistant
• Interaction works consistently across:
  • inline shortcut
  • right-click menu

Flow 3: Right click

• Trigger Ask menu/submenu

• No regression to existing Smart Window chat behavior

• No regression to Classic smart cursor behavior outside Smart Window

Figma Specs

• Light Mode

Comment 2

[echa]

Attachment: Bug 2034921 - Re-enable smart cursor and integrate with Smart Window r=#ai-frontend-reviewers

• Enable Smart Cursor actions in Smart Window behind browser.ml.chat.shortcuts.smartwindow and route selected text to the sidebar chat
• Update Smart Window context menus/shortcuts to use Smart Window-specific UI and remove unsupported options

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6825b3a4dc4e
https://hg.mozilla.org/integration/autoland/rev/36629cac1613
Re-enable smart cursor and integrate with Smart Window r=fluent-reviewers,flozia,bolsson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3fb67a77402
https://hg.mozilla.org/integration/autoland/rev/6bb372141c07
Revert "Bug 2034921 - Re-enable smart cursor and integrate with Smart Window r=fluent-reviewers,flozia,bolsson" for causing bc failures at browser_genai_actors.js

Comment 5

[Silaghi Andreea]

Backed out for causing bc failures at browser_genai_actors.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/genai/tests/browser/browser_genai_actors.js | test_actor_disabled - Missing expected exception. Actor disabled

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/948b055e8f6d
https://hg.mozilla.org/integration/autoland/rev/2e1d48565c3e
Re-enable smart cursor and integrate with Smart Window r=fluent-reviewers,flozia,bolsson

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2e1d48565c3e

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 154.0a1 (2026-06-19), however it seems that the Ask AI submenus from when we right click inside a page or from when we Right click a Tab are missing from Smart Window, we do have them in Classic Firefox.

Are these being implemented with a different bug ? should I log a seperate one ?

Comment 9

[echa]

Hi Rares, as discussed on Slack the right click inside a page (without highlighted text) is not in scope for this iteration. thanks!

Comment 10

[Rares Doghi, Desktop QA]

Updating the main status flag.

Comment 11

[echa]

Attachment: Bug 2034921 - Re-enable smart cursor and integrate with Smart Window

• Enable Smart Cursor actions in Smart Window behind browser.ml.chat.shortcuts.smartwindow and route selected text to the sidebar chat
• Update Smart Window context menus/shortcuts to use Smart Window-specific UI and remove unsupported options

Original Revision: https://phabricator.services.mozilla.com/D306022

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This patch enables Smart Cursor actions (e.g. Summarize, Explain this, Proofread) in Smart Window by routing them to the built-in assistant.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Open a Smart Window.
  Set prefs browser.ml.chat.shortcuts and browser.ml.chat.shortcuts.smartwindow to true
  Navigate to a page with selectable text.
  Select text and verify the Smart Cursor shortcut appears.
  Choose an action (e.g. Summarize).
  Verify the prompt is submitted to the Smart Window sidebar assistant.
  Verify Classic Window Smart Cursor behavior remains unchanged.
• Risk associated with taking this patch: low
• Explanation of risk level: The feature is isolated to Smart Window and is backed by existing Smart Cursor functionality.
• String changes made/needed?: Yes
• Is Android affected?: unknown

Comment 13

[echa]

Attachment: Bug 2034921 - Re-enable smart cursor and integrate with Smart Window

• Enable Smart Cursor actions in Smart Window behind browser.ml.chat.shortcuts.smartwindow and route selected text to the sidebar chat
• Update Smart Window context menus/shortcuts to use Smart Window-specific UI and remove unsupported options

Original Revision: https://phabricator.services.mozilla.com/D306022

Comment 14

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: This patch enables Smart Cursor actions (e.g. Summarize, Explain this, Proofread) in Smart Window by routing them to the built-in assistant.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Open a Smart Window.
  Set prefs browser.ml.chat.shortcuts and browser.ml.chat.shortcuts.smartwindow to true
  Navigate to a page with selectable text.
  Select text and verify the Smart Cursor shortcut appears.
  Choose an action (e.g. Summarize).
  Verify the prompt is submitted to the Smart Window sidebar assistant.
  Verify Classic Window Smart Cursor behavior remains unchanged.
• Risk associated with taking this patch: low
• Explanation of risk level: The feature is isolated to Smart Window and is backed by existing Smart Cursor functionality.
• String changes made/needed?: Yes
• Is Android affected?: unknown

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e0a9de161997
https://hg.mozilla.org/releases/mozilla-beta/rev/41875423fedb

Comment 16

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 153.0b12

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/09b173d32450
https://hg.mozilla.org/releases/mozilla-release/rev/0ef4c9446ba2

Comment 18

[Ed Lee :Mardak]

Release Note Request (optional, but appreciated)
[Why is this notable]: new smart window assistant interaction
[Affects Firefox for Android]: no
[Suggested wording]: Enabled Smart Cursor in Smart Window, allowing users to select text on a page to summarize, explain, or take other actions in the built-in assistant.
Select text on a page and get quick access to summarize, explain, and more using the built-in assistant.
[Links (documentation, blog post, etc)]: https://www.firefox.com/smart-window is needed to activate the feature and it's region restricted, so we should probably show the "progressive roll out" indicator

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.6 relnotes.

Comment 20

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 152.0.6