Closed Bug 2034970 Opened 4 months ago Closed 4 months ago

If user is closing multiple cards in "list" card view starting from the bottom, the toast message covers the next card's close button

Categories

(Firefox for Android :: Tabs, defect)

Firefox 150
All
Android
defect

Tracking

()

RESOLVED DUPLICATE of bug 2034962

People

(Reporter: parooweu, Unassigned)

Details

Attachments

(4 files)

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:150.0) Gecko/150.0 Firefox/150.0

Steps to reproduce:

Open multiple cards in list view, attempt to close them one by one rapidly starting from the bottom.

Actual results:

The toast message about the card being closed (allowing to undo the operation) covers the next card's close button

Expected results:

The close button should still be visible.

Hello, I can confirm this regression: prior to v150, a small amount of padding kept the bottom-most tab from being covered by the toast.

I've bisected and found the commit that caused this: https://bugzilla.mozilla.org/show_bug.cgi?id=2026821 - https://phabricator.services.mozilla.com/D291496

Hope it's alright that I tag the developer and reporter of the original request.

<dimen name="tab_tray_list_bottom_padding">80dp</dimen>

This is likely too small, having come down from 190dp, which was agreeably too large (1.5x the list entry size). This value doesn't seem to depend on the actual screen size/density. I can adjust the DPI high and low on two devices with varying screen size (Oneplus 8T and Pixel 5), both are affected equally.

Tried a few values and found a goldilocks:

  • 120dp is still too small, the list item outline is cut off under the toast.

  • 140dp fits better, roughly the space a list item would take.

  • 160dp is too large, it exceeds the size of the other list entries and leaves a gap between the undo toast and the last list item.

Flags: needinfo?(giorga)
Flags: needinfo?(calu)

Sorry, this is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=2034962. Moving notes there

Flags: needinfo?(giorga)
Flags: needinfo?(calu)
Status: UNCONFIRMED → RESOLVED
Type: enhancement → defect
Closed: 4 months ago
Component: General → Tabs
Duplicate of bug: 2034962
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: