2035009 - panel-list items in the migration wizard are vertically misaligned

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

I noticed this today, and it's a fairly recent regression.

15:32.82 INFO: Last good revision: 0b16302a254fb31bd65ec6bdeac410878983aeb1
15:32.82 INFO: First bad revision: f8622fd9691adc745836f73c2f7f476245a16f82
15:32.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0b16302a254fb31bd65ec6bdeac410878983aeb1&tochange=f8622fd9691adc745836f73c2f7f476245a16f82

STR:

1. Go to about:settings#general
2. Click "Import data"
3. Click on the browser / profile selection dropdown

ER:

The list of browsers and profiles that we can import from should be vertically aligned in the middle.

AR:

The list of browsers and profiles that we can import from appear to be too high up, vertically. See screenshot.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Attachment: Screenshot of the problem

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Attachment: How it should look

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2033862

:dao, since you are the author of the regressor, bug 2033862, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 2035009 - Fix vertical alignment of migration wizard panel-items. r?mconley

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 2035009 - Fix vertical alignment of migration wizard panel-items.

Original Revision: https://phabricator.services.mozilla.com/D296932

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: See https://bugzilla.mozilla.org/show_bug.cgi?id=2035009#c1

This is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=2033862 which is needed in 151.

It's strictly a cosmetic issue but looks broken enough that we shouldn't ship with this if possible.

• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Trivial fix.
• String changes made/needed?: none
• Is Android affected?: no

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/08c4f9b3680a
https://hg.mozilla.org/integration/autoland/rev/60fc0ae30af9
Fix vertical alignment of migration wizard panel-items. r=mconley

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/60fc0ae30af9

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/26476e22cac3
https://hg.mozilla.org/releases/mozilla-beta/rev/82fa07f846d9