2035045 - [Datepicker] Can't set the max day on mobile.

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[gueux+mozilla]

Attachment: Screenshot_20260426-114803_Firefox.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:149.0) Gecko/20100101 Firefox/149.0
Firefox for Android

Steps to reproduce:

Using input of type="date" with a max field, I try to set the date to the max with the datepicker on mobile (note that there is no problem on desktop). For example on
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/date#try_it I'd like to set the date to 2018-12-31.

Actual results:

2018-12-31 is not selectable, only 2018-12-30 and before. I also tried to set it manually with the pencil, but 31/12/2018 is "outside of limits" ("Hors limite: 31 déc. 2018" in my French locale).

Expected results:

I should be able to set the date to the max.

Comment 1

[gueux+mozilla]

Attachment: Screenshot_20260426-114745_Firefox.png

Comment 2

[gueux+mozilla]

The problem appears (at least) on 149 and 150, and only on mobile.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Corentin Bect [:corentin]]

Attachment: Bug 2035045 - Convert the date picker min and max dates to midnight UTC

MaterialDatePicker represents its dates in UTC milliseconds and asks its validator about each day as midnight UTC. DateValidatorPointForward.from() and DateValidatorPointBackward.before() need to use the same UTC representation. The min and max dates were passed in the device timezone instead, so each bound was a moment in time rather than a day.

As a consequence:

• The max day was greyed out in timezones ahead of UTC
• The min day was greyed out in timezones behind UTC
• The min day was greyed out in every timezone when the min date had a time of day

toLocalDayStartAsUtcMillis() drops the time of day rather than shifting it by the offset and returns midnight UTC on that day. For max="2018-12-31" in Paris, the Date is 2018-12-30T23:00Z. toLocalDayStartAsUtcMillis() reads this date as 2018-12-31 in Parisand returns 2018-12-31T00:00Z. Before this change, this max date would remain 2018-12-30T23:00Z, making 2018-12-31 an invalid date on the calendar.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a43defbbe84c
https://hg.mozilla.org/integration/autoland/rev/c0367a804c44
Convert the date picker min and max dates to midnight UTC r=android-reviewers,lmccracken

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c0367a804c44

Comment 7

[Donal Meehan [:dmeehan]]

Did you want to nominate this for the Fx156 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Fixed the date picker ignoring the last selectable day when a page set a maximum date.

Comment 8

[Corentin Bect [:corentin]]

[Tracking Requested - why for this release]: Fixed an issue where the date picker could prevent selecting the minimum or maximum allowed date.

Comment 9

[Corentin Bect [:corentin]]

Thanks Donal!

Comment 10

[Donal Meehan [:dmeehan]]

Thanks, moved the tracking to a release note request

Comment 11

[Donal Meehan [:dmeehan]]

Added to the Fx156 nightly release notes, please allow 30 minutes for the site to update.