2035083 - CSS highlights not rendering on inserted text nodes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[vrugtehagel]

Attachment: css-highlights-bug.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:149.0) Gecko/20100101 Firefox/149.0

Steps to reproduce:

I created a text node, constructed Range objects for it, added those to a CSS highlight (using CSS.highlights.set(...)), then inserted the text node into the document.

Actual results:

The text was not highlighted.

Expected results:

The text should have been highlighted. See attached test case.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Jan Jaeschke [:jjaschke]]

Thanks for catching this. Confirmed this works in Chrome, I'm working on a fix.

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2035083 - Fix CSS highlights not rendering on inserted text nodes. r?#layout

Allow detached ranges through the document check in highlight selection
population. Added two WPT reftests verifying highlights paint after
inserting a text node and after inserting a subtree containing a
highlighted range.

Comment 4

[Jan Jaeschke [:jjaschke]]

Try run.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2ab73e6e9589
https://hg.mozilla.org/integration/autoland/rev/597b1c2d66fd
Fix CSS highlights not rendering on inserted text nodes. r=layout-reviewers,emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59666 for changes under testing/web-platform/tests

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/597b1c2d66fd

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot