Closed Bug 2035137 Opened 6 months ago Closed 6 months ago

Perma [Tier 2] win ccov D:/task_177727943155584/build/src/parser/expat/expat/lib\xmlparse.c(139,12): fatal error: 'random_rand_s.h' file not found

Categories

(Core :: XML, defect, P5)

defect

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox150 --- unaffected
firefox151 --- unaffected
firefox152 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: RyanVM)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 external file)

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=562649691&repo=mozilla-central&task=VmTl19hbRKGRLI470xDAHw.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VmTl19hbRKGRLI470xDAHw/runs/0/artifacts/public/logs/live_backing.log


INFO -  mozmake[4]: Entering directory 'D:/task_177727943155584/workspace/obj-build/parser/html'
[task 2026-04-27T09:24:36.753+00:00] 09:24:36     INFO -  mkdir -p '.deps/'
[task 2026-04-27T09:24:36.756+00:00] 09:24:36     INFO -  mozmake[4]: Leaving directory 'D:/task_177727943155584/workspace/obj-build/parser/html'
[task 2026-04-27T09:24:36.785+00:00] 09:24:36     INFO -  mozmake[4]: Entering directory 'D:/task_177727943155584/workspace/obj-build/parser/html'
[task 2026-04-27T09:24:36.798+00:00] 09:24:36     INFO -  parser/html/Unified_cpp_parser_html0.obj
[task 2026-04-27T09:24:36.798+00:00] 09:24:36     INFO -  mozmake[4]: Leaving directory 'D:/task_177727943155584/workspace/obj-build/parser/html'
[task 2026-04-27T09:24:36.831+00:00] 09:24:36     INFO -  mozmake[4]: Entering directory 'D:/task_177727943155584/workspace/obj-build/parser/expat'
[task 2026-04-27T09:24:36.842+00:00] 09:24:36     INFO -  D:/task_177727943155584/build/src/parser/expat/expat/lib\xmlparse.c(139,12): fatal error: 'random_rand_s.h' file not found
[task 2026-04-27T09:24:36.842+00:00] 09:24:36     INFO -    139 | #  include "random_rand_s.h"
[task 2026-04-27T09:24:36.842+00:00] 09:24:36     INFO -        |            ^~~~~~~~~~~~~~~~~
[task 2026-04-27T09:24:36.843+00:00] 09:24:36     INFO -  1 error generated.
[task 2026-04-27T09:24:36.843+00:00] 09:24:36    ERROR -  mozmake[4]: *** [D:/task_177727943155584/build/src/config/rules.mk:578: moz_xmlparse.obj] Error 1
[task 2026-04-27T09:24:36.846+00:00] 09:24:36     INFO -  D:/task_177727943155584/fetches/clang/bin/clang.exe --driver-mode=cl -fms-compatibility-version=19.50 -Fomoz_xmlparse.obj -c  -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DHAVE_EXPAT_CONFIG_H -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -ID:/task_177727943155584/build/src/parser/expat -ID:/task_177727943155584/workspace/obj-build/parser/expat -ID:/task_177727943155584/workspace/obj-build/security/rlbox -ID:/task_177727943155584/workspace/obj-build/dist/include -ID:/task_177727943155584/workspace/obj-build/dist/include/nspr -ID:/task_177727943155584/workspace/obj-build/dist/include/nss -MD -DMOZILLA_CLIENT -FI D:/task_177727943155584/workspace/obj-build/mozilla-config.h -Gy -Zc:inline -Gw -D_HAS_EXCEPTIONS=0 -fcrash-diagnostics-dir=/d/task_177727943155584/public/build -fcrash-diagnostics-dir=/d/task_177727943155584/public/build -g1 -Xclang -load -Xclang D:/task_177727943155584/workspace/obj-build/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -W3 -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Winvalid-utf8 -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Werror=implicit-function-declaration -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option @D:/task_177727943155584/workspace/obj-build/code_coverage_cflags -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/moz_xmlparse.obj.pp -Xclang -MT -Xclang moz_xmlparse.obj   D:/task_177727943155584/build/src/parser/expat/expat/lib/moz_xmlparse.c
[task 2026-04-27T09:24:36.846+00:00] 09:24:36     INFO -  mozmake[4]: Leaving directory 'D:/task_177727943155584/workspace/obj-build/parser/expat'
[task 2026-04-27T09:24:36.847+00:00] 09:24:36     INFO -  mozmake[4]: Entering directory 'D:/task_177727943155584/workspace/obj-build/parser/expat'
[task 2026-04-27T09:24:36.863+00:00] 09:24:36     INFO -  parser/expat/moz_xmltok.obj

Set release status flags based on info from the regressing bug 2024039

:RyanVM, since you are the author of the regressor, bug 2024039, could you take a look?

For more information, please visit BugBot documentation.

Summary: Perma [TIer 2] win ccov D:/task_177727943155584/build/src/parser/expat/expat/lib\xmlparse.c(139,12): fatal error: 'random_rand_s.h' file not found → Perma [Tier 2] win ccov D:/task_177727943155584/build/src/parser/expat/expat/lib\xmlparse.c(139,12): fatal error: 'random_rand_s.h' file not found

I guess ccov is our only build that defined _WIN32? Seems strange.

#if defined(_WIN32)
#  include "random_rand_s.h"
#endif /* defined(_WIN32) */

This header defines writeRandomBytes_rand_s which is used in generate_hash_secret_salt, and we've stubbed out that function. I guess the most straightforward fix is to change 03_dont_generate_salt.patch to also stub that out include. Adding a blank random_rand_s.h would also work I guess but it feels like that would not work well with update bot.

I'm working on a Try push that basically does that already.

Flags: needinfo?(ryanvm)
Assignee: nobody → ryanvm

Bug 2024039 excluded the random_*.{c,h} files from vendoring on the
basis that they're dead code (the .c files aren't compiled, and
generate_hash_secret_salt is stubbed by 03_dont_generate_salt.patch).
That broke the Windows ccov build because xmlparse.c's _WIN32-gated
#include of random_rand_s.h still fires at file scope.

Extend 03_dont_generate_salt.patch to wrap the random_.h #include
block in #if 0 too. This keeps the random_
.{c,h} exclusion (no
misleading code-coverage data on dead source) while making the
exclusion safe on every platform: the #include never fires, so the
header doesn't have to exist.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Duplicate of this bug: 2035444
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: