2035159 - don't store an extra copy of compressed jpeg xl source data in the decoder

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 2035159. Don't store an extra copy of compressed jpeg xl source data in the decoder. r?saschanaz,#gfx-reviewers

SourceBufferIterator was designed for lexing image formats (ie "I want to parse a 4 byte height field"), whereas more modern codecs like jpegxl follow a model like "hand the binary blob to the libray and get back notifications".

With a little addition to SourceBufferIterator we are able to handle partially consuming the current chunk of data so that the decoder doesn't need to keep track of it and keep a copy of the data. Otherwise SourceBufferIterator would assume the whole chunk was complete and not send it to the decoder again. This might arise if say an animation frame was completed and the decoder yielded without consuming all of the available data.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c40c511d4467
https://hg.mozilla.org/integration/autoland/rev/0236c1b11f29
Don't store an extra copy of compressed jpeg xl source data in the decoder. r=saschanaz

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0236c1b11f29