2035353 - Rich search suggestion icons are forced into a square aspect ratio

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Drew Willcoxon :adw]

Attachment: screenshot

After bug 2012436, rich search suggestion icons are loaded here and then here in the favicon utils, where they're forced into a square aspect ratio. Not all rich suggestion icons are square, see screenshots.

Comment 1

[Drew Willcoxon :adw]

Attachment: browser toolbox

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 2035353 - Fix rich search suggestion icon aspect ratios.

I'd like to modify RemoteImageProtocolHandler so it takes a max dimension and
preserves the image's aspect ratio, but for now I think we should stop passing a
width and height to it so that it returns images at their native sizes and
aspect ratios. That's not any worse than before bug 2012436 D284071 landed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb52f12f1716
https://hg.mozilla.org/integration/autoland/rev/9fec9e4e4e57
Fix rich search suggestion icon aspect ratios. r=mak,urlbar-reviewers

Comment 5

[Drew Willcoxon :adw]

Attachment: Bug 2035353 - Fix rich search suggestion icon aspect ratios.

I'd like to modify RemoteImageProtocolHandler so it takes a max dimension and
preserves the image's aspect ratio, but for now I think we should stop passing a
width and height to it so that it returns images at their native sizes and
aspect ratios. That's not any worse than before bug 2012436 D284071 landed.

Original Revision: https://phabricator.services.mozilla.com/D297215

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This fixes stretching and distortion of images in Google search suggestions (rich search suggestions). See the screenshots in the bug for an example.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Trigger rich search suggestions and verify that the icons are not distorted
• Risk associated with taking this patch: low
• Explanation of risk level: No functional changes other than fixing the bug. This patch causes Firefox to load these images at their native size, and then the UI will shrink them down for display, which is what Firefox did before the regressing bug landed.
• String changes made/needed?: none
• Is Android affected?: no

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: This fixes stretching and distortion of images in Google search suggestions (rich search suggestions). See the screenshots in the bug for an example.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Trigger rich search suggestions and verify that the icons are not distorted
• Risk associated with taking this patch: low
• Explanation of risk level: No functional changes other than fixing the bug. This patch causes Firefox to load these images at their native size, and then the UI will shrink them down for display, which is what Firefox did before the regressing bug landed.
• String changes made/needed?: none
• Is Android affected?: no

Comment 8

[Drew Willcoxon :adw]

Attachment: Bug 2035353 - Fix rich search suggestion icon aspect ratios.

I'd like to modify RemoteImageProtocolHandler so it takes a max dimension and
preserves the image's aspect ratio, but for now I think we should stop passing a
width and height to it so that it returns images at their native sizes and
aspect ratios. That's not any worse than before bug 2012436 D284071 landed.

Original Revision: https://phabricator.services.mozilla.com/D297215

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9fec9e4e4e57

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/91b73973ba4b
https://hg.mozilla.org/releases/mozilla-beta/rev/e8798d78b4c4

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3a80ad95fc12
https://hg.mozilla.org/releases/mozilla-release/rev/8d2744a8af3b

Comment 12

[Petruta Horea [:phorea]]

Reproduced the square rich suggestion icons with Firefox 150.0.1.
Verified as fixed using latest Nightly 152.0a1 and Firefox 151 beta 6 on Win 11 and mac OS 15.

Comment 13

[Petruta Horea [:phorea]]

Verified as fixed on Firefox 150.0.2 under Win 11, macOS 15 and Ubuntu 24.