RenameField doesn't get NULL/NOT NULL correct

RESOLVED FIXED in Bugzilla 2.18

Status

()

--
critical
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: bbaetz, Assigned: bbaetz)

Tracking

({dataloss})

2.17.4
Bugzilla 2.18
x86
Linux
dataloss
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Not only does it look at the wrong column, it gets the test backwards.

Patch coming. Note that all other users of RenameField call ChangeFieldType on
the field later on (either directly afterwards, or several montsh later for the
bug_activity case), so we don't have to do any fixup for past behaviour.

This does affect the count patch, though
(Assignee)

Comment 1

16 years ago
Created attachment 121839 [details] [diff] [review]
fix

The third column is [2], and its NOT NULL, if the 'is null' column is not not
NULL. Make sense? :)

Tested on 4.0.12, and I checked that 3.23 has the same column ordering.
(Assignee)

Updated

16 years ago
Attachment #121839 - Flags: review?(justdave)
Comment on attachment 121839 [details] [diff] [review]
fix

doh.  Wonder if the columns were different in MySQL 3.22 and nobody noticed
when they changed...
Attachment #121839 - Flags: review?(justdave) → review+
Flags: approval+
(Assignee)

Comment 3

16 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.