Closed
Bug 203540
Opened 22 years ago
Closed 22 years ago
RenameField doesn't get NULL/NOT NULL correct
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bbaetz, Assigned: bbaetz)
References
Details
(Keywords: dataloss)
Attachments
(1 file)
|
644 bytes,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
Not only does it look at the wrong column, it gets the test backwards.
Patch coming. Note that all other users of RenameField call ChangeFieldType on
the field later on (either directly afterwards, or several montsh later for the
bug_activity case), so we don't have to do any fixup for past behaviour.
This does affect the count patch, though
|
Assignee | |
Comment 1•22 years ago
|
||
The third column is [2], and its NOT NULL, if the 'is null' column is not not
NULL. Make sense? :)
Tested on 4.0.12, and I checked that 3.23 has the same column ordering.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #121839 -
Flags: review?(justdave)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 121839 [details] [diff] [review]
fix
doh. Wonder if the columns were different in MySQL 3.22 and nobody noticed
when they changed...
Attachment #121839 -
Flags: review?(justdave) → review+
|
|
||
Updated•22 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
||
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.18
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•