Not only does it look at the wrong column, it gets the test backwards. Patch coming. Note that all other users of RenameField call ChangeFieldType on the field later on (either directly afterwards, or several montsh later for the bug_activity case), so we don't have to do any fixup for past behaviour. This does affect the count patch, though
Created attachment 121839 [details] [diff] [review] fix The third column is , and its NOT NULL, if the 'is null' column is not not NULL. Make sense? :) Tested on 4.0.12, and I checked that 3.23 has the same column ordering.
Attachment #121839 - Flags: review?(justdave)
Comment on attachment 121839 [details] [diff] [review] fix doh. Wonder if the columns were different in MySQL 3.22 and nobody noticed when they changed...
Attachment #121839 - Flags: review?(justdave) → review+
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
You need to log in before you can comment on or make changes to this bug.