Closed Bug 2035506 Opened 6 months ago Closed 6 months ago

about:welcome first screen onboarding impression ping is dropped

Categories

(Firefox :: Messaging System, defect, P1)

defect
Points:
3

Tracking

()

VERIFIED FIXED
152 Branch
Tracking Status
firefox152 --- verified

People

(Reporter: mjung, Assigned: mjung)

References

Details

(Whiteboard: [omc][tos])

Attachments

(1 external file)

We've noticed that EASY SETUP_.. screens (typically the first about:welcome screen a user would see) was having lower than expected impressions when looking at impression data for this experiment. More puzzling is that this was also happening in control. The running theory was that TOU was cannibalizing that first screen impression as it renders at the same time as the spotlight and before the user accepts TOU, but that shouldnt be the case as any pings sent before TOU acceptance are preserved and should be sent afterwards.

Zooming out of the dashboard, it looks like the dropoff happens around late September of 2025. Looking at what landed in Fx143, I found 1977258 which I suspect has regressed the first screen impression telemetry. It seems like the changes made it so onBrowserReady() is now triggered by TELEMETRY_TOU_ACCEPTED_OR_INELIGIBLE which fires after TOU acceptance. This is delays enabling ActivityStream telemetry (browser.newtabpage.activity-stream.telemetry) until after TOU acceptance which is too late for about:welcome's first screen impression as it renders prior to TOU acceptance.

I think the fix is we may want to set browser.newtabpage.activity-stream.telemetry at init time in AboutNewTab.init()

@Rares, do you happen to have capacity to verify if the first about:welcome screen impression ping is dropped when a user is eligible to see TOU onboarding modal and if the regression stems from 1977258?

Flags: needinfo?(rdoghi)

Hi @Mimi, unfortunately I cant get a regression range for this issue because those builds are all nightly builds and they never show the TOS modal or the About:welcome page, However I tried a manual regression range with Release and Beta builds and this is what I uncovered:

Beta 142.0b9 - is good and we see the impression after accepting the TOS modal.
Release 142.0 - not good, we no longer see the impression after accepting the TOS modal but we do see it if the TOS modal never shows up.
Beta 143.0b1 - not good, we no longer see the impression after accepting the TOS modal but we do see it if the TOS modal never shows up.

This is what I was looking for, not sure its the right one :
"messaging_system.event_page": "about:welcome",
"messaging_system.addon_version": "20250818151251",
"messaging_system.event": "IMPRESSION",
"messaging_system.locale": "en-US"

Also I used this user.js to make sure the TOS modal does not show up:

user_pref("security.ssl.enable_ocsp_stapling", false);
user_pref("browser.preonboarding.onTrainRolloutPopulation", 0);
user_pref("browser.preonboarding.enabled", false);
user_pref("browser.preonboarding.requireAction", false);
user_pref("datareporting.policy.currentPolicyVersion", 2);
user_pref("datareporting.policy.minimumPolicyVersion", 2);

Flags: needinfo?(rdoghi)
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → mjung
Points: --- → 3
Regressions: 1977258
Pushed by mjung@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bf5b0a2c9e5a https://hg.mozilla.org/integration/autoland/rev/425b1251408b Resolve AW first screen impression dropped due to AS telemetry being set too late r=home-newtab-reviewers,chutten,omc-reviewers,jprickett,thecount
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a7c7d85d64cd https://hg.mozilla.org/integration/autoland/rev/f06683f46fd0 Revert "Bug 2035506 - Resolve AW first screen impression dropped due to AS telemetry being set too late r=home-newtab-reviewers,chutten,omc-reviewers,jprickett,thecount" for causing xp failures @ test_TelemetryFeed.js

Woops, sorry about that - I didn't catch the test failure in my try run.

Flags: needinfo?(mjung)
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 152 Branch → ---
Flags: qe-verify+
Priority: P2 → P1
Pushed by mjung@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7c8761acc107 https://hg.mozilla.org/integration/autoland/rev/d6e66e65fe19 Resolve AW first screen impression dropped due to AS telemetry being set too late r=home-newtab-reviewers,chutten,omc-reviewers,jprickett,thecount
Status: REOPENED → RESOLVED
Closed: 6 months ago → 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

HI @Mimi, Im having some issues verifying this bug, I only see this impression:

messaging_system.addon_version 20260517203605
messaging_system.event IMPRESSION
messaging_system.event_page spotlight
messaging_system.locale en-US

In the past after accepting the TOS I would see this one :

messaging_system.addon_version 20250818151251
messaging_system.event IMPRESSION
messaging_system.event_page about:welcome
messaging_system.locale en-US

Now It never shows up, even if I start Firefox and the TOS modal never shows up, the About:welcome impression never shows up, am I missing something here ?

Flags: needinfo?(mjung)

Thanks for flagging, let me take a look today.

Flags: needinfo?(mjung)

Thanks for clearing it up on slack, always prompt with the help ! This issue is verified as fixed in our latest Nightly 152.0a1 (2026-05-15) builds.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-done-c152/b151]
Flags: qe-verify+
QA Contact: rdoghi
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: