203556 - Bookmarks toolbar folders should act like menus

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Steven Tucker]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6

for example when you click 'File' on a regular menu, you can move the mouse to
the right to 'Edit' and the 'File' menu will close, replaced by the 'Edit' menu
without clicking anything.

This should be at least an optional behavior for the bookmarks toolbar if the
items on the toolbar are folders.  Right now you can move to another folder, but
it only highlights and the original folder clicked stays open.  One has to click
twice on the new folder, once to close the original, and once to open the new
one before it will display.

Reproducible: Always

Steps to Reproduce:
1. Place 2 or more folders in bookmark toolbar
2. Click one to drop down
3. Move mouse to the right and hover on next bookmarks toolbar folder

Actual Results:  
nothing, new folder is only highlighted, its contents are not displayed

Expected Results:  
display folder contents

Comment 1

[David Tenser [:djst]]

Agreed. When you click one bookmarks folder on the bookmarks toolbar and then
hover to the next, that folder should open instead.

Updating summary, OS > All

Comment 2

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 142215 ***

Comment 3

[Sébastien Delahaye]

Jesse, you sure? Bookmarks code is forked in Phoenix.

Comment 4

[Jesse Ruderman]

seb: I duped it because I think this bug is unlikely to be fixed in Phoenix
before Phoenix replaces Mozilla.

Comment 5

[Pierre Chanial]

Jesse: for the moment, there are too many bugs in the seamonkey bookmark
component: I had not the time to go through them yet. On the other hand, I know
all the reported phoenix bookmark bugs. So, the thing that would help me best
atm and I'd be grateful to the persons that can do it, would be to link the
seamonkey/phoenix bugs through the dependency list.

Comment 6

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 7

[Rayon]

(my first bug-comment. sorry if not using properly)

Strongly agreed. I heavily use these bookmark folders.
Click saver :)

Comment 8

[basic]

Attachment: patch

here's a patch, probably needs more comments and testing.

Comment 9

[basic]

Attachment: patch v2

make functions generic, should make it easier to port over to seamonkey.

Comment 10

[basic]

Attachment: patch v3

just realized that there's no need to check if the button is of type "menu"
since the event fires from a menupopup, the button should always be of type
"menu"

Comment 11

[basic]

Attachment: patch v3.1

bah fixing bad spacing/tab stuff

Comment 12

[basic]

Attachment: patch v4

renamed some functions, moved onpopupshowing/hidden to menupopups where
possible,  cut down on unneeded checks, and skip when the menu is already open.

Comment 13

[basic]

Attachment: patch 4.1

forgot to escape the &'s

Comment 14

[basic]

Attachment: patch v5

decided to rework the patch. Simpler and less changes. This will make the code
almost identical to the seamonkey patch as well.

Comment 15

[Bernard Alleysson]

It really enhances the bookmarks toolbar experience. I would like to have this
for 1.0. Plus there is a patch waiting for review ...

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

+ since there's a patch. 

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 144189 [details] [diff] [review]
patch v5

reviewing and checking in on the branch and trunk for some testing. let's see
if people like this concept...

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Marking this fixed for you. 

Comment 19

[Ben Basson]

I've ported basic's patch as an extension for anyone wanting to use this
functionality before 0.9.
Thanks for the work, basic.

Comment 20

[Ben Basson]

Oh, sorry for further bugspam... I guess the URL might be mildly useful here:
http://extensions.cusser.net/bookmarktoolbarfix/bookmarktoolbarfix.xpi

Comment 21

[Mike Connor [:mconnor]]

er, as of 5/21 builds on branch and trunk, this is a core feature, no extension
needed :)

works nicely IMO

Comment 22

[José Jeria]

Just a thought, if you have folders and regular bookmarks on the personal
toolbar, if you click on a folder it will expand, and the folders next to it
will act like a menu, but if you click on a folder to expand it, and the a
bookmark, the first click will do nothing (it will collapse the expanded
folder), you will have to click twice to activate the bookmark.

Comment 23

[Peter Lairo]

Great fix! I've been waiting for this for a LONG time. :-D

I noticed that if i selected a menu in the personal toolbar (PT), and then move
over a link (not a menu) in the PT, that the last opened menu does not collapse.
It would be nice if it did collapse. Another bug?

Comment 24

[Brian Polidoro]

Also it would be great if you have a bookmark toolbar folder open and mouse over
a main menu that main menu item opens.

Comment 25

[Jesse Ruderman]

Brian: I think that would result in menus opening unexpectedly.

Comment 26

[Brian Polidoro]

(In reply to comment #25)
> Brian: I think that would result in menus opening unexpectedly.

Oh well I use my bookmark toolbar right next to my main menu so it's sort of an
extension of my main menu.  I'll try putting my bookmark toolbar on the other
side of the address bar.  This way if I want something on the menu I won't go to
my bookmark toolbar.

Comment 27

[Paolo Marani]

I'm sorry but i think this fix produces some odd interaction between folder menu
and "popup" contextual RMB menu.

Assume in your personal toolbar you have some folder containing each one a list
of bookmark.

Steps to reproduce:
1. Click on a folder in personal bookmark bar to show the bookmark menu
2. Move the mouse cursor over an item inside the menu
3. Click RMB to open the contextual menu, but DONT select any action
4. Move away the mouse up to open another folder in personal toolbar with a
mouseover.

Expected: The popup menu should close

Unfortunately, the popup contextual menu REMAIN ZOMBIE on screen, and there is
NO WAY to get rid of it, unless selecting something into!

Well, i think an easy fix would be to close all pending contextual menu any time
the user open a folder menu due tu a mouseover.

Can someone reproduce this issue ?

Comment 28

[Peter Lairo]

(In reply to comment #27)
> Expected: The popup menu should close

I disagree. The expected result should be that the context menu remains, and no
additional menus should open until the user dismisses the menu by clicking
elsewhere. This seems to be the way Windows context menus behave.

> Well, i think an easy fix would be to close all pending contextual menu any 
> time the user open a folder menu due tu a mouseover.

It may seem odd to the user if his menu disappears because his mouse happened to
hover over some PART of the screen that we define as closing his dialog.

> Can someone reproduce this issue ?

Yes. 
(Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040611 Firefox/0.8.0+)

Comment 29

[Paolo Marani]

I changed my idea, you are right, menu should close only clicking away!
Anyway, having the popup menu stuck zombie like now should be fixed.
Regards,

Comment 30

[Martijn Wargers (dead)]

*** Bug 177563 has been marked as a duplicate of this bug. ***

Comment 31

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change