2035575 - Wire in-tree application-services through the fat AAR and artifact-build pipelines

Status: REOPENED

(Firefox Build System :: Android Studio and Gradle Integration, task, P2)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

With --enable-appservices-in-tree, application-services builds locally but its outputs (the full-megazord AAR, component AARs, and the desktop libmegazord.so consumed by Android JVM unit tests via libsForTests) aren't yet wired through the fat AAR pipeline or downloadable in artifact builds. We need to package the megazord and its NSS runtime dependencies into the fat AAR alongside geckoview, publish all a-s AARs to local maven during fat AAR builds, generalize artifact downloads so that artifact builds pull in-tree a-s outputs, and add desktop architecture support so libsForTests consumes the in-tree desktop megazord.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Package `libmegazord.so` as an extra archive for downstream consumers r?#build,nalexander

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Publish all app-services AARs to local maven during fat AAR builds r?#build,nalexander

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Stage `libmegazord.so` under appservices destdir for `libsForTests` gradle tasks r?#build,nalexander

Comment 4

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Extract Android and host native libraries from `target.maven.zip` for artifact builds r?#build,nalexander

Comment 5

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Normalize app-services groupId and gate subproject inclusion on dependency-download context r?nalexander

Comment 6

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Replace `--maven-zip` with general-purpose `--artifact-filter` for artifact downloads r?#build,nalexander

Comment 7

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Include NSS runtime dependencies in megazord extra archive for desktop `libsForTests` r?#build,nalexander

Comment 8

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Add desktop architecture support (Linux, macOS, Windows) to the fat AAR pipeline for `libsForTests` r?#build,nalexander

Comment 9

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Extract `libsForTests` native libraries for JVM unit tests r?nalexander

Comment 10

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: WIP: Bug 2035575 - Enable `--appservices-in-tree` by default on all platforms r?#build,nalexander

Comment 11

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Namespace fat-AAR output under geckoview r?nalexander

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/770110e8ec2c
https://hg.mozilla.org/integration/autoland/rev/fec3cd1adcbf
Revert "Bug 2035575 - Replace `--maven-zip` with general-purpose `--artifact-filter` for artifact downloads r=nalexander,firefox-build-system-reviewers"

Comment 13

[amarc]

Backed out for causing Android multi-arch fat AAR Shippable bustages

• Backout link
• Push with failures
• Failure Log

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/34156e006095
https://hg.mozilla.org/mozilla-central/rev/91d63a7b3380
Replace `--maven-zip` with general-purpose `--artifact-filter` for artifact downloads r=nalexander,firefox-build-system-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/236a5b3aae03
https://hg.mozilla.org/integration/autoland/rev/10187cf63c32
Replace `--maven-zip` with general-purpose `--artifact-filter` for artifact downloads r=nalexander,firefox-build-system-reviewers

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/10187cf63c32

Comment 17

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Integrate megazord AAR into fat AAR pipeline alongside geckoview r?nalexander

The fat AAR build needs the full-megazord AAR alongside geckoview's. The
megazord output lands under appservices/, and artifact builds fetch
target.maven.zip so they pick up both AARs.

The geckoview archive build also publishes every app-services component
(via :publishAppServicesAndroid), not just the megazord, so the
standalone android-components and fenix builds can resolve them as Maven
AARs from target.maven.zip.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b524f6db8fd
https://hg.mozilla.org/integration/autoland/rev/221becbf5090
Namespace fat-AAR output under geckoview r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/663d2a7510ad
https://hg.mozilla.org/integration/autoland/rev/0de553b56b80
Extract Android and host native libraries from `target.maven.zip` for artifact builds r=nalexander,geckoview-reviewers

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/221becbf5090
https://hg.mozilla.org/mozilla-central/rev/0de553b56b80

Comment 20

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Point the Android `glean-build` at the `glean_parser` venv r?#build,nalexander

Comment 21

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Vendor `proguard-rules-consumer-jna.pro` r?nalexander,markh

The full megazord applies it via consumerProguardFiles, so excluding it from
vendoring breaks the build at mergeReleaseConsumerProguardFiles.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b0d3ea91668
https://hg.mozilla.org/integration/autoland/rev/f8e6700f2b0f
Vendor `proguard-rules-consumer-jna.pro` r=nalexander

Comment 23

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f8e6700f2b0f

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5f9b667c6b95
https://hg.mozilla.org/integration/autoland/rev/6a6a7e2a62f1
Revert (Bug 2035575, Bug 2035579) for causing BR bustages

Comment 25

[amarc]

Backed out for causing BR bustages

• Backout link
• Push with failures
• Failure Log

Comment 26

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/6a6a7e2a62f1

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b54cb1020f5d
https://hg.mozilla.org/integration/autoland/rev/e79e33873d86
Vendor `proguard-rules-consumer-jna.pro` r=nalexander,markh

Comment 28

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/e79e33873d86

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/87a9fad7336c
https://hg.mozilla.org/integration/autoland/rev/cc90095f1c0e
Point the Android `glean-build` at the `glean_parser` venv r=nalexander,firefox-build-system-reviewers,geckoview-reviewers

Comment 30

[Silaghi Andreea]

Backed out at dev request.
https://hg.mozilla.org/integration/autoland/rev/0fa4c4931a2d

Comment 31

[Alex Hochheiden [:ahochheiden] [he/him]]

Thanks.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b4005d0833dd
https://hg.mozilla.org/integration/autoland/rev/326d8f50bf72
Point the Android `glean-build` at the `glean_parser` venv r=nalexander,firefox-build-system-reviewers,geckoview-reviewers

Comment 33

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/326d8f50bf72

Comment 34

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Keep a confirm failure task from outranking the test it confirms r?ahal

Comment 35

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Add a `duplicate` transform to copy another kind's tasks with overrides r?ahal

Manually duplicating every task definition produced by a kind lets the copy
drift as the source changes. Test variants already avoid this for individual
test tasks, but differences compiled into artifacts require varying the whole
kind so each configuration gets its own build.

Comment 36

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services in tree r?nalexander,ahal

This will be deleted once app-services in tree is enabled by default. The
duplicate tasks are set to tier 3 so that a regression in app-services does
not cause a backout, and a daily cron job schedules them to minimize the cost
of the duplicate set of tasks. We will monitor it for a while before committing
to app-services in tree being the CI default.

Comment 37

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Add an action to generate linker symbol inputs from a static archive r?#build,nalexander

A module definition file needs literal symbol names, so the patterns a symbol
pattern file holds are resolved against the static library the shared library
is linked from.

Comment 38

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Let a generated file depend on a Rust library r?#build,nalexander

A generated file that takes a Rust archive as input needs the Rust library
built first, but Cargo produces the archive as a side effect of the Rust
library target, so no rule names it and Make cannot order the two.

Comment 39

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Add a `WHOLE_ARCHIVE` moz.build primitive r?#build,nalexander

A library whose symbols are resolved by name at run time has nothing
referencing them at link time, so the linker keeps none of the archive members
that define them.

Comment 40

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Export the megazord's UniFFI ABI without the symbol stub r?#build,nalexander

UniFFI symbols are resolved by name at run time, but the stub retained only one
archive member per crate and did not populate the Windows export table.
Non-Windows builds now link the Rust archive whole, while Windows generates a
.def from its selected symbols.

Linking the archive whole also pulls in mozpkix, so only Windows links it
separately. All platforms now export only the selected ABI.

Comment 41

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Stop the Android megazord from freeing `bionic` memory with `mozjemalloc` r?#build,nalexander

libmegazord.so is loaded through JNA rather than linked into libxul.
Linking it against mozglue makes Rust's free resolve to mozjemalloc,
while bionic APIs such as realpath return allocations owned by libc,
causing Fenix to crash during startup. Depending on nss preserves the build
order, so Cargo still cannot run before libmozglue.so exists.

Folded NSS continues to use mozjemalloc. Rust never takes ownership of NSS
allocations and releases NSS objects through NSS APIs. The check_binary guard
runs only in automation and prevents a direct libmozglue.so dependency from
returning.

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8d5e2d55eb2d
https://hg.mozilla.org/integration/autoland/rev/f59460d18424
Package `libmegazord.so` as an extra archive for downstream consumers r=nalexander,firefox-build-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/cfefd2d06bc5
https://hg.mozilla.org/integration/autoland/rev/3bfae93a3f53
Stage `libmegazord.so` under appservices destdir for `libsForTests` gradle tasks r=nalexander,firefox-build-system-reviewers,geckoview-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/0a9b29deab78
https://hg.mozilla.org/integration/autoland/rev/2d8fa11ba9ed
Integrate megazord AAR into fat AAR pipeline alongside geckoview r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/cc9172f8ccfb
https://hg.mozilla.org/integration/autoland/rev/6486c9763b40
Normalize app-services groupId and gate subproject inclusion on dependency-download context r=nalexander,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/2ee56ae7d616
https://hg.mozilla.org/integration/autoland/rev/2d5b8957876e
Include NSS runtime dependencies in megazord extra archive for desktop `libsForTests` r=nalexander,firefox-build-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/88a848b4b851
https://hg.mozilla.org/integration/autoland/rev/4fafadaf5483
Extract `libsForTests` native libraries for JVM unit tests r=nalexander,geckoview-reviewers

Comment 43

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f59460d18424
https://hg.mozilla.org/mozilla-central/rev/3bfae93a3f53
https://hg.mozilla.org/mozilla-central/rev/2d8fa11ba9ed
https://hg.mozilla.org/mozilla-central/rev/6486c9763b40
https://hg.mozilla.org/mozilla-central/rev/2d5b8957876e
https://hg.mozilla.org/mozilla-central/rev/4fafadaf5483

Comment 44

[Cosmin Sabou [:CosminS]]

Backed out for causing Bug 2065509.

Backout link: https://hg-edge.mozilla.org/mozilla-central/rev/a33c90571e92de766016d68eb74994cec1c0a75e

Comment 45

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is also linked to failures for a version increase simulation pushed to Try today (firefox-main code, only some Firefox version numbers increased). See the failures for the last three platforms listed there. They are similar to the ones for a Try push for this bug.

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7fa9999fd9d
https://hg.mozilla.org/integration/autoland/rev/c70faaf77543
Stop the Android megazord from freeing `bionic` memory with `mozjemalloc` r=firefox-build-system-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/bc856ca9c0ae
https://hg.mozilla.org/integration/autoland/rev/e47ef1193b10
Package `libmegazord.so` as an extra archive for downstream consumers r=nalexander,firefox-build-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/b18ed3f1370a
https://hg.mozilla.org/integration/autoland/rev/3c117c53449f
Stage `libmegazord.so` under appservices destdir for `libsForTests` gradle tasks r=nalexander,firefox-build-system-reviewers,geckoview-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/0b3478add5d2
https://hg.mozilla.org/integration/autoland/rev/4be64d93d1b2
Integrate megazord AAR into fat AAR pipeline alongside geckoview r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/9147aab02684
https://hg.mozilla.org/integration/autoland/rev/c62854db6762
Normalize app-services groupId and gate subproject inclusion on dependency-download context r=nalexander,android-reviewers
https://github.com/mozilla-firefox/firefox/commit/e801d566be03
https://hg.mozilla.org/integration/autoland/rev/8c4d422c2b82
Include NSS runtime dependencies in megazord extra archive for desktop `libsForTests` r=nalexander,firefox-build-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/8de196ab6b58
https://hg.mozilla.org/integration/autoland/rev/693f59d5be8f
Extract `libsForTests` native libraries for JVM unit tests r=nalexander,geckoview-reviewers

Comment 47

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c70faaf77543
https://hg.mozilla.org/mozilla-central/rev/e47ef1193b10
https://hg.mozilla.org/mozilla-central/rev/3c117c53449f
https://hg.mozilla.org/mozilla-central/rev/4be64d93d1b2
https://hg.mozilla.org/mozilla-central/rev/c62854db6762
https://hg.mozilla.org/mozilla-central/rev/8c4d422c2b82
https://hg.mozilla.org/mozilla-central/rev/693f59d5be8f

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0915e7abf67
https://hg.mozilla.org/integration/autoland/rev/18eec9ce96dc
Let a generated file depend on a Rust library r=firefox-build-system-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/d5c733ee24bb
https://hg.mozilla.org/integration/autoland/rev/77b132b5acfa
Keep a confirm failure task from outranking the test it confirms r=ahal,taskgraph-reviewers

Comment 49

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/18eec9ce96dc
https://hg.mozilla.org/mozilla-central/rev/77b132b5acfa

Comment 50

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2035575 - Link the Android megazord against `mozglue` again r?#build,nalexander

The megazord stopped linking mozglue in D320332 so that a Rust free would
not reach bionic allocations. The vendored application-services no longer
calls std::fs::canonicalize on Android, so the megazord can use mozjemalloc
like every other Gecko library and the check_binary guard can assert the
dependency is present rather than absent.

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/acc54bb6ef53
https://hg.mozilla.org/integration/autoland/rev/4838b6c7cabf
Add an action to generate linker symbol inputs from a static archive r=firefox-build-system-reviewers,sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/d436c321ed7b
https://hg.mozilla.org/integration/autoland/rev/a79ec6d1aadb
Add desktop architecture support (Linux, macOS, Windows) to the fat AAR pipeline for `libsForTests` r=nalexander,firefox-build-system-reviewers,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/5c2121970343
https://hg.mozilla.org/integration/autoland/rev/f77b2a48ba0e
Export the megazord's UniFFI ABI without the symbol stub r=firefox-build-system-reviewers,sergesanspaille

Comment 52

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4838b6c7cabf
https://hg.mozilla.org/mozilla-central/rev/a79ec6d1aadb
https://hg.mozilla.org/mozilla-central/rev/f77b2a48ba0e