2035622 - Always show an add shortcut button for New Tab shortcuts

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Comment 1

[Irene Ni [:ini]]

Attachment: Bug 2035622 - Always show an add shortcut button for New Tab shortcuts. r=thecount

Comment 2

[Irene Ni [:ini]]

Attachment: Bug 2035622 - Make add shortcut button part of shortcuts arrow key navigation order. r=#home-newtab-reviewers

Comment 3

[Irene Ni [:ini]]

Attachment: Bug 2035622 - Include option to Add in New Tab shortcuts context menu. r=#home-newtab-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4eb5d723d627
https://hg.mozilla.org/integration/autoland/rev/c9b51eea20db
Always show an add shortcut button for New Tab shortcuts. r=thecount

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c9b51eea20db

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5748b16d3f0f
https://hg.mozilla.org/integration/autoland/rev/6e85ffe7b0fe
Revert "Bug 2035622 - Always show an add shortcut button for New Tab shortcuts. r=thecount" for causing M-trainhop mochitests failures.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing M-trainhop mochitests failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/asrouter/tests/browser/browser_asrouter_newtab_messages.js | test_show_newtab_message - Uncaught exception in test - Waiting for asrouter-newtab-message - timed out after 50 tries.

Comment 8

[amarc]

backout merged to central: https://hg.mozilla.org/mozilla-central/rev/6e85ffe7b0fe

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ca7a756722c9
https://hg.mozilla.org/integration/autoland/rev/32bf656530b0
Always show an add shortcut button for New Tab shortcuts. r=thecount
https://github.com/mozilla-firefox/firefox/commit/c15bd37a7ab5
https://hg.mozilla.org/integration/autoland/rev/eed4389ac3f3
Make add shortcut button part of shortcuts arrow key navigation order. r=thecount

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/32bf656530b0
https://hg.mozilla.org/mozilla-central/rev/eed4389ac3f3

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7d664b3bf1e
https://hg.mozilla.org/integration/autoland/rev/2ccf1d86b818
Include option to Add in New Tab shortcuts context menu. r=thecount,fluent-reviewers,bolsson

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ccf1d86b818

Comment 13

[Mathew Hodson]

Should this bug still be open? It looks like all the commits landed in Firefox 154 and they weren't backed out after bug 2035622 comment #12

Comment 14

[Irene Ni [:ini]]

Thanks for the ping, this bug should be resolved now.