Open Bug 2035662 Opened 3 months ago Updated 3 months ago

Use consistent attribute/class names for boolean view properties/states

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

People

(Reporter: adw, Unassigned)

References

Details

(Whiteboard: [sng])

See: https://phabricator.services.mozilla.com/D296491?id=1258342#inline-1609876

There are a bunch of boolean "properties" we set on elements in the urlbar view. Sometimes we use attributes, sometimes class names; sometimes we prefix with "is" and "has", sometimes we don't. Examples:

[is-top-pick]
[has-url]
[open]
[selected]
[pinned]
.with-bottom-url

We should pick a consistent convention and use it.

Nova might be a nice opportunity to polish this up.

You need to log in before you can comment on or make changes to this bug.