Closed Bug 2035675 Opened 19 days ago Closed 9 days ago

[wpt-sync] Sync PR 59468 - [Masonry] Implement fill-reverse for indefinite size containers

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 59468 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59468
Details from upstream follow.

Celeste Pan <celestepan@microsoft.com> wrote:

[Masonry] Implement fill-reverse for indefinite size containers

Implement fill-reverse for the case of alignment in an indefinite
stacking axis. The only case where this would happen is in the columns
layout with align-content, in which case we would use the intrinsic
stacking axis size to help us determine placement.

This change also moves the fill-reverse code into PlaceGridLanesItems
after RunGridLanesPlacementPhase, using a new method
ReverseChildrenInDirection, so that we can have access to the stacking
axis size before we perform any reversals. This also helps us to keep
the placement code and fill-reverse logic in separate areas for better
maintainability.

A follow-up change will be needed to handle OOF items in both
fill-reverse and regular content alignment in grid-lanes. At the moment,
we're attempting to move the static positions of the OOF items before
any OOF items have actually been placed.

Bug: 343257585
Change-Id: I2ea3504852bae46aaf33748834bf1ece4753e894
Reviewed-on: https://chromium-review.googlesource.com/7718181
WPT-Export-Revision: 6d47d8bd0d903692b6af2a7167be6aa5748d5442

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 125 tests

Status Summary

Firefox

PASS: 2
FAIL: 24[GitHub] 123[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 14
FAIL: 10

Safari

FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/48ebd17aecdc
https://hg.mozilla.org/mozilla-central/rev/d2690285149e

Status: NEW → RESOLVED
Closed: 9 days ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.