Closed Bug 2035688 Opened 19 days ago Closed 9 days ago

[wpt-sync] Sync PR 59396 - layout: Use a consistent definition of "document white space"

Tracking

()

Status:

RESOLVED FIXED

Milestone:

152 Branch

Tracking Flags:

Tracking

Status

firefox152

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

19 days ago

Sync web-platform-tests PR 59396 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59396
Details from upstream follow.

Martin Robinson <mrobinson@igalia.com> wrote:

layout: Use a consistent definition of "document white space"

Because the definition of "document white space" differed in various
places in Servo layout, it was possible for the flexbox container
builder to expect to be able to build an inline formatting context from
text that was ultimately determined to be empty by the inline formatting
context builder. This led to a BoxSlot not being properly filled (a
thing that should never happen) and an assertion failing.

This change fixes that issue.

Testing: This change adds a new WPT crash test.
Fixes: #43550.

Reviewed in servo/servo#44424

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

19 days ago

Component: web-platform-tests → Layout: Flexbox

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

18 days ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=115f67cc2813b1b2d57542f0d9fd1c1ed6c7daa4

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

17 days ago

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1312 tests and 12 subtests

Status Summary

Firefox

OK : 349
PASS: 1[GitHub] 25[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 4401[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 5304[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 5308[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 5309[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 128[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 157[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 158[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 159[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/align-self-016.html [wpt.fyi]: FAIL
/css/css-flexbox/content-height-with-scrollbars.html [wpt.fyi]: FAIL [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview], PASS [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
/css/css-flexbox/dynamic-orthogonal-flex-item.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-aspect-ratio-img-column-008.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-aspect-ratio-img-row-017.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-container-max-content-001.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-container-min-content-001.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-item-max-height-min-content.html [wpt.fyi]: FAIL
/css/css-flexbox/flex-item-max-width-min-content.html [wpt.fyi]: FAIL
/css/css-flexbox/gap-019.html [wpt.fyi]: FAIL
/css/css-flexbox/grandchild-span-height.html [wpt.fyi]: FAIL
/css/css-flexbox/multiline-shrink-to-fit.html [wpt.fyi]: FAIL
/css/css-flexbox/table-as-item-min-height-1.html [wpt.fyi]: FAIL
/css/css-flexbox/table-as-item-stretch-cross-size-5.html [wpt.fyi]: FAIL
/css/css-flexbox/alignment/flex-align-baseline-column-vert-lr-rtl-wrap-reverse.html [wpt.fyi]: FAIL
/css/css-flexbox/alignment/flex-align-baseline-column-vert-rl-rtl-wrap-reverse.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-001.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-002.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-003.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-006.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-007.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-008.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-009.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-013.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-014.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-020.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/row-002.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/row-003.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/row-004.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/row-007.html [wpt.fyi]: FAIL
/css/css-flexbox/intrinsic-size/row-wrap-002.tentative.html [wpt.fyi]: FAIL
/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html [wpt.fyi]: SKIP
/css/css-flexbox/fieldset-as-container-justify-center.tentative.html [wpt.fyi]
- .item 1: FAIL
/css/css-flexbox/flex-basis-013.html [wpt.fyi]
- .container 1: FAIL
- .container 2: FAIL
- .container 3: FAIL
- .container 4: FAIL
- .container 5: FAIL
/css/css-flexbox/flex-container-max-content-002.tentative.html [wpt.fyi]
- .flex 2: FAIL
- .flex 3: FAIL
- .flex 5: FAIL
- .flex 6: FAIL
- .flex 8: FAIL
- .flex 9: FAIL
- .flex 11: FAIL
- .flex 12: FAIL
- .flex 14: FAIL
- .flex 15: FAIL
- .flex 17: FAIL
- .flex 18: FAIL
- .flex 20: FAIL
- .flex 21: FAIL
- .flex 23: FAIL
- .flex 24: FAIL
/css/css-flexbox/flex-container-min-content-002.tentative.html [wpt.fyi]
- .flex 2: FAIL
- .flex 3: FAIL
- .flex 5: FAIL
- .flex 6: FAIL
- .flex 8: FAIL
- .flex 9: FAIL
- .flex 11: FAIL
- .flex 12: FAIL
- .flex 14: FAIL
- .flex 15: FAIL
- .flex 17: FAIL
- .flex 18: FAIL
- .flex 20: FAIL
- .flex 21: FAIL
- .flex 23: FAIL
- .flex 24: FAIL
/css/css-flexbox/flex-item-percentage-height-img-001.html [wpt.fyi]
- .flex-item 2: FAIL
/css/css-flexbox/flex-shorthand-calc.html [wpt.fyi]
- e.style['flex'] = "sign(1em - 1px) sibling-index()" should set flex-basis: FAIL
- e.style['flex'] = "sign(1em - 1px) sibling-index()" should set flex-grow: FAIL
- e.style['flex'] = "sign(1em - 1px) sibling-index()" should set flex-shrink: FAIL
- e.style['flex'] = "sign(1em - 1px) sibling-index()" should not set unrelated longhands: FAIL
/css/css-flexbox/inline-flexbox-wrap-vertically-width-calculation.html [wpt.fyi]
- .inline-flexbox 2: FAIL
- .inline-flexbox 4: FAIL
- .inline-flexbox 6: FAIL
- .inline-flexbox 8: FAIL
- .inline-flexbox 10: FAIL
- .inline-flexbox 12: FAIL
- .inline-flexbox 14: FAIL
- .inline-flexbox 16: FAIL
/css/css-flexbox/position-relative-percentage-top-001.html [wpt.fyi]
- .border 1: FAIL [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt], PASS [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
/css/css-flexbox/alignment/flex-align-baseline-line-clamp-001.tentative.html [wpt.fyi]
- .target > * 3: FAIL
- .target > * 15: FAIL
- .target > * 19: FAIL
- .target > * 23: FAIL
/css/css-flexbox/alignment/flex-align-baseline-line-clamp-002.tentative.html [wpt.fyi]
- .target > * 3: FAIL
- .target > * 4: FAIL
- .target > * 15: FAIL
- .target > * 16: FAIL
- .target > * 19: FAIL
- .target > * 20: FAIL
- .target > * 23: FAIL
- .target > * 24: FAIL
/css/css-flexbox/alignment/flex-align-baseline-line-clamp-003.tentative.html [wpt.fyi]
- .target > * 3: FAIL
- .target > * 15: FAIL
- .target > * 19: FAIL
- .target > * 23: FAIL
/css/css-flexbox/alignment/flex-align-baseline-multicol-001.html [wpt.fyi]
- .target > * 3: FAIL
- .target > * 7: FAIL
/css/css-flexbox/alignment/flex-align-baseline-multicol-002.html [wpt.fyi]
- .target > * 1: FAIL
- .target > * 3: FAIL
- .target > * 5: FAIL
- .target > * 7: FAIL
/css/css-flexbox/alignment/flex-align-baseline-multicol-003.html [wpt.fyi]
- .target > * 3: FAIL
- .target > * 7: FAIL
/css/css-flexbox/alignment/flex-align-baseline-table-002.html [wpt.fyi]
- .target > * 1: FAIL
- .target > * 3: FAIL
/css/css-flexbox/alignment/multiline-align-self.html [wpt.fyi]
- .flexbox 21: FAIL
- .flexbox 22: FAIL
- .flexbox 23: FAIL
- .flexbox 24: FAIL
- .flexbox 29: FAIL
- .flexbox 30: FAIL
- .flexbox 31: FAIL
- .flexbox 32: FAIL
- .flexbox 37: FAIL
- .flexbox 38: FAIL
- .flexbox 39: FAIL
- .flexbox 40: FAIL
- .flexbox 45: FAIL
- .flexbox 46: FAIL
- .flexbox 47: FAIL
- .flexbox 48: FAIL
/css/css-flexbox/getcomputedstyle/first-line-computed-style.html [wpt.fyi]
- first-line-computed-style: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-005.html [wpt.fyi]
- body > div 1: FAIL
/css/css-flexbox/intrinsic-size/col-wrap-019.html [wpt.fyi]
- body > div 1: FAIL
/css/css-flexbox/intrinsic-size/row-005.html [wpt.fyi]
- .floating-flexbox 1: FAIL
- .floating-flexbox 2: FAIL
- .floating-flexbox 3: FAIL
- .floating-flexbox 4: FAIL
- .floating-flexbox 5: FAIL
- .floating-flexbox 6: FAIL
- .floating-flexbox 7: FAIL
- .floating-flexbox 8: FAIL
/css/css-flexbox/intrinsic-size/row-008.html [wpt.fyi]
- .min-width-flexbox 1: FAIL
- .min-width-flexbox 2: FAIL
- .min-width-flexbox 3: FAIL
- .min-width-flexbox 4: FAIL
- .min-width-flexbox 5: FAIL
- .min-width-flexbox 6: FAIL
- .min-width-flexbox 7: FAIL
- .min-width-flexbox 8: FAIL
- .min-width-flexbox 9: FAIL
- .min-width-flexbox 10: FAIL
- .min-width-flexbox 11: FAIL
/css/css-flexbox/intrinsic-size/row-use-cases-001.html [wpt.fyi]
- left < right: FAIL
- no overflow: FAIL
- same widths: FAIL
- zero width: FAIL
- same heights: FAIL
- no overflow 2: FAIL
/css/css-flexbox/intrinsic-size/row-wrap-001.html [wpt.fyi]
- .floating-flexbox 1: FAIL
- .floating-flexbox 2: FAIL
- .floating-flexbox 4: FAIL
- .floating-flexbox 5: FAIL
/css/css-flexbox/parsing/flex-computed.html [wpt.fyi]
- Property flex value 'calc(10 + (sign(20cqw - 10px) * 5)) calc(10 + (sign(20cqw - 10px) * 5)) 1px': FAIL
/css/css-flexbox/parsing/flex-valid.html [wpt.fyi]
- e.style['flex'] = "calc(10 + (sign(20cqw - 10px) * 5)) calc(10 + (sign(20cqw - 10px) * 5)) 1px" should set the property value: FAIL

Tests Disabled in Gecko Infrastructure

/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html [wpt.fyi]: SKIP

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

11 days ago

Depends on: 2037341

Pulsebot

Comment 3

•

9 days ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/04145335f282 https://hg.mozilla.org/integration/autoland/rev/e5ccb36ac370 [wpt PR 59396] - layout: Use a consistent definition of "document white space", a=testonly

Silaghi Andreea

Comment 4

•

9 days ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e5ccb36ac370

Status: NEW → RESOLVED

Closed: 9 days ago

status-firefox152: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 152 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 59396 - layout: Use a consistent definition of "document white space"

Categories

(Core :: Layout: Flexbox, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 3

Comment 4