203569 - Change name in WinXP "Internet" start menu AND group name appearing in task bar to Mozilla Firebird

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6

WindowsXP can group similar application windows to one tab in
task bar.
It should be "Firebird" instead of "Phoenix" that is currently
displayed.

Reproducible: Always

Steps to Reproduce:
1. Turn on task grouping in Control Panel of Windows XP
2. Open multiple Firebird Windows and other applications until the taskbar
overflows and grouping occurs
Actual Results:  
"Phoenix" is displayed in the taskbar

Expected Results:  
"Firebird" is displayed in the taskbar

Comment 1

[Sébastien Delahaye]

David, can you reproduce it?

Comment 2

[David Tenser [:djst]]

Indeed.

Comment 3

[Sébastien Delahaye]

Not sure, but isn't splash.rc to blame?
http://lxr.mozilla.org/mozilla/source/browser/app/splash.rc#70

Comment 4

[Will Levine]

could this also be responsible for the fact that when set as the default
browser, the name Phoenix shows up in the XP start menu for default browser?

Comment 5

[David Tenser [:djst]]

Seb, how on earth did you find that one? ;)

> could this also be responsible for the fact that when set as the
> default browser, the name Phoenix shows up in the XP start menu for
> default browser?

Most probably yes. Updating summary.

Comment 6

[Robert Parenton]

Ben Gooder fixed this today (2003-05-12) and should appear in the nightlies
tomorrow.

Comment 7

[David Tenser [:djst]]

-> Fixed.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/app&command=DIFF_FRAMESET&file=splash.rc&rev1=1.6&rev2=1.7&root=/cvsroot

Comment 8

[noririty]

group name is still 'Phoenix'

Comment 9

[Robert Parenton]

Attachment: Patch to possibly fix 'Phoenix' in group name on WinXP (comment 8)

Someone running XP needs to compile with this patch to see if it will fix the
problem.  I have a feeling it will, but even if it doesn't, this still needs to
get in for the renaming.

Comment 10

[Robert Parenton]

Comment on attachment 123470 [details] [diff] [review]
Patch to possibly fix 'Phoenix' in group name on WinXP (comment 8)

Requesting patch review from bryner.

Comment 11

[Asa Dotzler [:asa]]

Ben just landed this.

Comment 12

[Simon Paquet [:sipaq]]

verified.