2035769 - [wpt-sync] Sync PR 59508 - layout: Do not assume layout data structures exist during queries

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 59508 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59508
Details from upstream follow.

Martin Robinson <[e-mail]> wrote:

layout: Do not assume layout data structures exist during queries

Data structures, such as the fragment tree and and stacking context
tree, might not exist even after a layout if there is no root element.
This change makes it so that the code stops asusming they exist. This
does expose us to cases where logic errors may mean we try to run a
script query without running the appropriate phase of layout first, but
that is better than panicking.

Testing: This change adds a new WPT crash test.
Fixes: #<!-- nolink -->44536.

Reviewed in servo/servo#44560

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=affb577f4505263c7ff585b8239c3204059fdc30

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS : 1[GitHub] 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 1

Chrome

PASS : 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/nodes/crashtests/multiple-append-mutated-in-unload.https.html [wpt.fyi]: TIMEOUT

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a620f477e9cc
https://hg.mozilla.org/integration/autoland/rev/d65ddfd6d30a
[wpt PR 59508] - layout: Do not assume layout data structures exist during queries, a=testonly

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/d65ddfd6d30a