2036005 - Show TLS error code on the "Secure Connection Failed" error page

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Lars Eggert [:lars]]

When a TLS handshake fails with an SSL error that isn't individually registered in the error registry (e.g. SSL_ERROR_DECRYPT_ERROR_ALERT), the nssFailure2 error page shows only generic text with no indication of what specifically went wrong. This makes it hard to diagnose what error triggered the page.

Suggested by :djackson in https://bugzilla.mozilla.org/show_bug.cgi?id=2033073#c17

Comment 1

[Lars Eggert [:lars]]

Attachment: Bug 2036005 - Show SSL error code on nssFailure2 fallback error pages r=valentin,kershaw,djackson,#necko-reviewers,#nss-reviewers

Unregistered SSL errors that fall through to the nssFailure2 config in the
error registry now show their error code (e.g. SSL_ERROR_DECRYPT_ERROR_ALERT)
on the "Secure Connection Failed" error page, consistent with how registered
errors like SSL_ERROR_NO_CYPHER_OVERLAP already behave. Also removes a broken
third descriptionParts entry in the nssFailure2 config that referenced a
Fluent string that was never defined.

Comment 2

[Lars Eggert [:lars]]

:manuel, is there anything in this PR that should change?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e504e64895d9
https://hg.mozilla.org/integration/autoland/rev/ce31cb127ddc
Show SSL error code on nssFailure2 fallback error pages r=kershaw,necko-reviewers

Comment 4

[Manuel Bucher [:manuel]]

Sorry, didn't have time to look at the patch. Clearing needinfo. I think showing the exact error code is good. Bug 2027209 did the same (roughly at the same time) for some other networking errors. Thanks for working on it and landing :)

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ce31cb127ddc