2036030 - Unified search button popup doesn't close when installing open search engine

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Moritz Beier [:mbeier]]

STR:

1. Add the searchbar to the navbar
2. (important) make sure there are no suggestions in the searchbar when it's empty (i.e. there is no form history) for example by using a new profile
3. Go to any site that offers open search, e.g. https://developer.mozilla.org/

Expected:
Installs the new engine, enters search mode and closes the popup.

Actual:
Installs the new engine, enters search mode but doesn't close the popup.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 2036030 - Unified search button popup doesn't close when installing open search engine. r?#urlbar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd75bb610a21
https://hg.mozilla.org/integration/autoland/rev/ad83d06e53dc
Unified search button popup doesn't close when installing open search engine. r=urlbar-reviewers,search-reviewers,daleharvey

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ad83d06e53dc

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.