Closed Bug 2036116 Opened 6 months ago Closed 6 months ago

Atom marking check in CheckWeakMapEntryMarking doesn't get run

Categories

(Core :: JavaScript: GC, defect, P3)

defect

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox152 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 external file)

Jan spotted that the check for the atom marking state for sybols is dead code in CheckWeakMapEntryMarking:

https://searchfox.org/firefox-main/rev/4272397b835a480b1be6cee142d0fa39e166dbc6/js/src/gc/Verifier.cpp#1205-1208,1219-1231

This is verifier code that is not present in release builds.

Assignee: nobody → jcoppeard

This is part of a bunch of checks that run in debug builds and when
CheckWeakMapMarking zeal mode is enabled.

Pushed by jcoppeard@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/197971968019 https://hg.mozilla.org/integration/autoland/rev/e1ad4ef67882 Fix bug that meant weak map marking for symbols wasn't checked r=spidermonkey-reviewers,jandem
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: